linux-kernel - RE: [PATCH] perf stat: Fix multi-line metric output in JSON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CO6PR11MB563587FE3F6CC5475E9D8864EE189@CO6PR11MB5635.namprd11.prod.outlook.com>
Date:   Mon, 5 Dec 2022 18:07:39 +0000
From:   "Wang, Weilin" <weilin.wang@...el.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
CC:     Namhyung Kim <namhyung@...nel.org>, Jiri Olsa <jolsa@...nel.org>,
        "Ingo Molnar" <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Ian Rogers <irogers@...gle.com>,
        "Hunter, Adrian" <adrian.hunter@...el.com>,
        "linux-perf-users@...r.kernel.org" <linux-perf-users@...r.kernel.org>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Zhengjun Xing <zhengjun.xing@...ux.intel.com>,
        James Clark <james.clark@....com>,
        Athira Jajeev <atrajeev@...ux.vnet.ibm.com>
Subject: RE: [PATCH] perf stat: Fix multi-line metric output in JSON

Yes, no problem. 

Thanks, 
Weilin

-----Original Message-----
From: Arnaldo Carvalho de Melo <acme@...nel.org> 
Sent: Monday, December 5, 2022 5:04 AM
To: Wang, Weilin <weilin.wang@...el.com>
Cc: Namhyung Kim <namhyung@...nel.org>; Jiri Olsa <jolsa@...nel.org>; Ingo Molnar <mingo@...nel.org>; Peter Zijlstra <peterz@...radead.org>; LKML <linux-kernel@...r.kernel.org>; Ian Rogers <irogers@...gle.com>; Hunter, Adrian <adrian.hunter@...el.com>; linux-perf-users@...r.kernel.org; Kan Liang <kan.liang@...ux.intel.com>; Zhengjun Xing <zhengjun.xing@...ux.intel.com>; James Clark <james.clark@....com>; Athira Jajeev <atrajeev@...ux.vnet.ibm.com>
Subject: Re: [PATCH] perf stat: Fix multi-line metric output in JSON

Em Fri, Dec 02, 2022 at 07:31:59PM +0000, Wang, Weilin escreveu:
> Namhyung, it works. Thanks!

Thanks, applied and added a Tested-by: Weilin, ok?

- Arnaldo
 
> -----Original Message-----
> From: Namhyung Kim <namhyung@...il.com> On Behalf Of Namhyung Kim
> Sent: Friday, December 2, 2022 11:05 AM
> To: Arnaldo Carvalho de Melo <acme@...nel.org>; Jiri Olsa <jolsa@...nel.org>
> Cc: Ingo Molnar <mingo@...nel.org>; Peter Zijlstra <peterz@...radead.org>; LKML <linux-kernel@...r.kernel.org>; Ian Rogers <irogers@...gle.com>; Hunter, Adrian <adrian.hunter@...el.com>; linux-perf-users@...r.kernel.org; Kan Liang <kan.liang@...ux.intel.com>; Zhengjun Xing <zhengjun.xing@...ux.intel.com>; James Clark <james.clark@....com>; Athira Jajeev <atrajeev@...ux.vnet.ibm.com>; Wang, Weilin <weilin.wang@...el.com>
> Subject: [PATCH] perf stat: Fix multi-line metric output in JSON
> 
> When a metric produces more than one values, it missed to print the opening bracket.
> 
> Fixes: ab6baaae2735 ("perf stat: Fix JSON output in metric-only mode")
> Reported-by: "Wang, Weilin" <weilin.wang@...el.com>
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> ---
> Weilin, could you please verify it fixes your problem?
> 
>  tools/perf/util/stat-display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c index f1ee4b052198..8d0bdd57163d 100644
> --- a/tools/perf/util/stat-display.c
> +++ b/tools/perf/util/stat-display.c
> @@ -440,7 +440,7 @@ static void new_line_json(struct perf_stat_config *config, void *ctx)  {
>  	struct outstate *os = ctx;
>  
> -	fputc('\n', os->fh);
> +	fputs("\n{", os->fh);
>  	if (os->prefix)
>  		fprintf(os->fh, "%s", os->prefix);
>  	aggr_printout(config, os->evsel, os->id, os->nr);
> --
> 2.39.0.rc0.267.gcb52ba06e7-goog

-- 

- Arnaldo