linux-kernel - Re: [PATCH 1/1] arm64: dts: rockchip: rk356x: Fix PCIe register and range mappings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221205181519.7e5diejvhiynqmv5@core>
Date:   Mon, 5 Dec 2022 19:15:19 +0100
From:   Ondřej Jirman <megi@....cz>
To:     Chukun Pan <amadeus@....edu.cn>
Cc:     aholmes@...om.net, devicetree@...r.kernel.org,
        ezequiel@...guardiasur.com.ar, frank-w@...lic-files.de,
        frattaroli.nicolas@...il.com, heiko@...ech.de,
        krzysztof.kozlowski+dt@...aro.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-rockchip@...ts.infradead.org, macromorgan@...mail.com,
        mark.kettenis@...all.nl, michael.riesch@...fvision.net,
        pgwipeout@...il.com, robh+dt@...nel.org, robin.murphy@....com,
        s.hauer@...gutronix.de, yifeng.zhao@...k-chips.com
Subject: Re: [PATCH 1/1] arm64: dts: rockchip: rk356x: Fix PCIe register and
 range mappings

On Tue, Dec 06, 2022 at 12:23:22AM +0800, Chukun Pan wrote:
> > The register and range mappings for the PCIe controller in Rockchip's
> > RK356x SoCs are incorrect. Replace them with corrected values from the
> > vendor BSP sources, updated to match current DT schema.
> 
> Hi, Andrew
> 
> This patch broken pcie3x2 on my board.

That's because 32bit mapping for pcie3x2 config should start at 0xf0000000 and
the patch declares it incorrectly at 0xf2000000.

https://megous.com/dl/tmp/6d1a04195112b1e0.png

> And the wireless card on pcie2x1 is still not working.

> [    0.405341] pcieport 0000:00:00.0: of_irq_parse_pci: failed with rc=-22
> [    0.670522] rockchip-dw-pcie 3c0800000.pcie: can't request region for resource [mem 0xf2000000-0xf2ffffff]
> [    0.671527] rockchip-dw-pcie: probe of 3c0800000.pcie failed with error -16
> [    7.354521] pci 0000:00:00.0: of_irq_parse_pci: failed with rc=-22
> [    7.355116] mt7921e 0000:01:00.0: enabling device (0000 -> 0002)
> [    7.355812] mt7921e: probe of 0000:01:00.0 failed with error -28

That's ENOSPC. Who knows where it's comming from. Something for you to debug. ;)

regards,
	o.
> 
> --
> Thanks,
> Chukun
> 
> -- 
> 2.25.1
>