linux-kernel - Re: [PATCH v1] rust: alloc: remove the `borrow` module (`ToOwned`, `Cow`)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y496ZhJF2ND+ND3L@liuwe-devbox-debian-v2>
Date:   Tue, 6 Dec 2022 17:22:46 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     ojeda@...nel.org
Cc:     Wedson Almeida Filho <wedsonaf@...il.com>,
        Alex Gaynor <alex.gaynor@...il.com>,
        Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
        Björn Roy Baron <bjorn3_gh@...tonmail.com>,
        rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
        patches@...ts.linux.dev, Josh Triplett <josh@...htriplett.org>,
        Wei Liu <wei.liu@...nel.org>
Subject: Re: [PATCH v1] rust: alloc: remove the `borrow` module (`ToOwned`,
 `Cow`)

On Tue, Dec 06, 2022 at 02:05:19AM +0100, ojeda@...nel.org wrote:
> From: Miguel Ojeda <ojeda@...nel.org>
> 
> The `Cow` type [1] requires that its generic parameter type implements
> the `ToOwned` trait [2], which provides a method to create owned data
> from borrowed data, usually by cloning.
> 
> However, it is infallible, and thus in most cases it is not useful for
> the kernel. [3]
> 
> Therefore, introduce `cfg(no_borrow)` to remove the `borrow` module
> (which contains `ToOwned` and `Cow`) from `alloc`.
> 
> Link: https://doc.rust-lang.org/alloc/borrow/enum.Cow.html [1]
> Link: https://doc.rust-lang.org/alloc/borrow/trait.ToOwned.html [2]
> Link: https://lore.kernel.org/rust-for-linux/20221204103153.117675b1@GaryWorkstation/ [3]
> Cc: Gary Guo <gary@...yguo.net>
> Cc: Wedson Almeida Filho <wedsonaf@...il.com>
> Cc: Josh Triplett <josh@...htriplett.org>
> Signed-off-by: Miguel Ojeda <ojeda@...nel.org>

Reviewed-by: Wei Liu <wei.liu@...nel.org>