linux-kernel - Re: [PATCH v3 2/4] iov_iter: Add a function to extract a page list from an iterator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1251303.1670351737@warthog.procyon.org.uk>
Date:   Tue, 06 Dec 2022 18:35:37 +0000
From:   David Howells <dhowells@...hat.com>
To:     Logan Gunthorpe <logang@...tatee.com>
Cc:     dhowells@...hat.com, Al Viro <viro@...iv.linux.org.uk>,
        Christoph Hellwig <hch@....de>,
        John Hubbard <jhubbard@...dia.com>,
        Matthew Wilcox <willy@...radead.org>,
        linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
        Christoph Hellwig <hch@...radead.org>,
        Jeff Layton <jlayton@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/4] iov_iter: Add a function to extract a page list from an iterator

Logan Gunthorpe <logang@...tatee.com> wrote:

> If this is going to be a general replacement for iov_iter_get_pages()
> it's going to need to pass through gup_flags. My recent patchset added
> versions with these and I think it should be in during the next merge
> cycle. [1]

Cool.  Note that the current iov_iter_get_pages2() is broken, which is why Al
wanted a replacement.  It should not be taking a ref on the pages in an
XARRAY, BVEC or PIPE - and it should be pinning rather than getting a ref on
pages in IOVEC or UBUF if the buffer is being read into.  I'm guessing that
your changes move the latter decision to the caller?

David