linux-kernel - Re: [PATCH v3 0/4] ext4: fix two bug_on in __es_tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167036049592.156498.14036136511112425546.b4-ty@mit.edu>
Date:   Tue,  6 Dec 2022 16:01:50 -0500
From:   "Theodore Ts'o" <tytso@....edu>
To:     Baokun Li <libaokun1@...wei.com>, linux-ext4@...r.kernel.org
Cc:     "Theodore Ts'o" <tytso@....edu>, linux-kernel@...r.kernel.org,
        yi.zhang@...wei.com, ritesh.list@...il.com,
        adilger.kernel@...ger.ca, yukuai3@...wei.com, jack@...e.cz
Subject: Re: [PATCH v3 0/4] ext4: fix two bug_on in __es_tree_search

On Wed, 26 Oct 2022 12:23:06 +0800, Baokun Li wrote:
> V1->V2:
> 	In patch 2, when imode is not set to S_IFREG, the inode also needs
> 	to be initialized. Otherwise, the check can be bypassed, causing
> 	the BUG_ON. (found in the review by yangerkun)
> V2->V3:
> 	a. add EXT4_IGET_BAD flag to prevent unexpected bad inode.
> 	b. check bad quota inode in vfs_setup_quota_inode() instead of in
> 	   ext4_quota_enable() for more generic approach to this problem.
> 	c. add helper to check quota inums.
> 
> [...]

Applied, thanks!

[1/4] ext4: fix bug_on in __es_tree_search caused by bad quota inode
      commit: c7e9666f28ba9bdeeb99fb0c60a27dbb88f452f4
[2/4] ext4: add helper to check quota inums
      commit: 9c4883f1b41181f2096e2ee4e98111008b77165c
[3/4] ext4: add EXT4_IGET_BAD flag to prevent unexpected bad inode
      commit: 10f525fda2faff81f6cfce2a6bc4b50a5254d9ea
[4/4] ext4: fix bug_on in __es_tree_search caused by bad boot loader inode
      commit: db14233edaf579153d8c92bf3a0ba27ceb87eabc

Best regards,
-- 
Theodore Ts'o <tytso@....edu>