linux-kernel - Re: [PATCH v6 tty-next 1/4] serial: 8250_pci: Add serial8250_pci_setup_port definition in 8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y4+/pBgrHmAdp4FV@smile.fi.intel.com>
Date:   Wed, 7 Dec 2022 00:18:12 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Tharunkumar.Pasumarthi@...rochip.com
Cc:     ilpo.jarvinen@...ux.intel.com, Kumaravel.Thiagarajan@...rochip.com,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
        gregkh@...uxfoundation.org, jirislaby@...nel.org,
        macro@...am.me.uk, jay.dolan@...esio.com, cang1@...e.co.uk,
        u.kleine-koenig@...gutronix.de, wander@...hat.com,
        etremblay@...tech-controls.com, jk@...abs.org,
        biju.das.jz@...renesas.com, geert+renesas@...der.be,
        phil.edworthy@...esas.com, lukas@...ner.de,
        UNGLinuxDriver@...rochip.com, colin.i.king@...il.com
Subject: Re: [PATCH v6 tty-next 1/4] serial: 8250_pci: Add
 serial8250_pci_setup_port definition in 8250_pcilib.c

On Tue, Dec 06, 2022 at 07:09:29PM +0000, Tharunkumar.Pasumarthi@...rochip.com wrote:
> > From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > Sent: Thursday, December 1, 2022 5:42 PM

> > > struct pci_dev;
> > 
> > + blank line
> > 
> > struct uart_8250_port;
> 
> Is the blank line required here?

Strictly speaking no, it's not required. But it shows the group of generic
forward declarations and specific to the topic (driver / subsystem).

-- 
With Best Regards,
Andy Shevchenko