linux-kernel - Re: [PATCH security-next] selinux: use sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHC9VhTq7s4Le59LS_Ygwju_AHUiDsL-B_mAaT1Ftaj_gB=MnQ@mail.gmail.com>
Date:   Tue, 6 Dec 2022 17:49:21 -0500
From:   Paul Moore <paul@...l-moore.com>
To:     ye.xingchen@....com.cn
Cc:     stephen.smalley.work@...il.com, eparis@...isplace.org,
        selinux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH security-next] selinux: use sysfs_emit() to instead of scnprintf()

On Tue, Dec 6, 2022 at 3:26 PM Paul Moore <paul@...l-moore.com> wrote:
>
> On Mon, Dec 5, 2022 at 6:32 AM <ye.xingchen@....com.cn> wrote:
> > From: ye xingchen <ye.xingchen@....com.cn>
> >
> > Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> > should only use sysfs_emit() or sysfs_emit_at() when formatting the
> > value to be returned to user space.
> >
> > Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
> > ---
> >  security/selinux/avc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> SELinux uses securityfs, not sysfs, for entries under /sys/fs/selinux.

Sorry, a little mental mistake in the above, SELinux uses *selinuxfs*
and not sysfs.

Thanks to the little birdie that pointed this out :)

-- 
paul-moore.com