linux-kernel - Re: [PATCH] regulator: core: Use different devices for resource allocation and DT lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 6 Dec 2022 12:59:09 +0800
From:   kernel test robot <lkp@...el.com>
To:     cy_huang <u0084500@...il.com>, broonie@...nel.org
Cc:     oe-kbuild-all@...ts.linux.dev, djrscally@...il.com,
        hdegoede@...hat.com, markgross@...nel.org, lgirdwood@...il.com,
        mcoquelin.stm32@...il.com, alexandre.torgue@...s.st.com,
        gene_chen@...htek.com, chiaen_wu@...htek.com,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org,
        ChiYuan Huang <cy_huang@...htek.com>
Subject: Re: [PATCH] regulator: core: Use different devices for resource
 allocation and DT lookup

Hi cy_huang,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on broonie-regulator/for-next]
[also build test ERROR on linus/master v6.1-rc8 next-20221206]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/cy_huang/regulator-core-Use-different-devices-for-resource-allocation-and-DT-lookup/20221206-110134
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
patch link:    https://lore.kernel.org/r/1670295548-19598-1-git-send-email-u0084500%40gmail.com
patch subject: [PATCH] regulator: core: Use different devices for resource allocation and DT lookup
config: x86_64-allmodconfig
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/7e148c1165ffaafd082958ed931135458ade32d3
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review cy_huang/regulator-core-Use-different-devices-for-resource-allocation-and-DT-lookup/20221206-110134
        git checkout 7e148c1165ffaafd082958ed931135458ade32d3
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/platform/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/platform/x86/intel/int3472/clk_and_regulator.c: In function 'skl_int3472_register_regulator':
>> drivers/platform/x86/intel/int3472/clk_and_regulator.c:188:54: error: 'int3742' undeclared (first use in this function); did you mean 'int3472'?
     188 |         int3472->regulator.rdev = regulator_register(int3742->dev,
         |                                                      ^~~~~~~
         |                                                      int3472
   drivers/platform/x86/intel/int3472/clk_and_regulator.c:188:54: note: each undeclared identifier is reported only once for each function it appears in


vim +188 drivers/platform/x86/intel/int3472/clk_and_regulator.c

   138	
   139	int skl_int3472_register_regulator(struct int3472_discrete_device *int3472,
   140					   struct acpi_resource_gpio *agpio)
   141	{
   142		const struct int3472_sensor_config *sensor_config;
   143		char *path = agpio->resource_source.string_ptr;
   144		struct regulator_consumer_supply supply_map;
   145		struct regulator_init_data init_data = { };
   146		struct regulator_config cfg = { };
   147		int ret;
   148	
   149		sensor_config = int3472->sensor_config;
   150		if (IS_ERR(sensor_config)) {
   151			dev_err(int3472->dev, "No sensor module config\n");
   152			return PTR_ERR(sensor_config);
   153		}
   154	
   155		if (!sensor_config->supply_map.supply) {
   156			dev_err(int3472->dev, "No supply name defined\n");
   157			return -ENODEV;
   158		}
   159	
   160		init_data.constraints.valid_ops_mask = REGULATOR_CHANGE_STATUS;
   161		init_data.num_consumer_supplies = 1;
   162		supply_map = sensor_config->supply_map;
   163		supply_map.dev_name = int3472->sensor_name;
   164		init_data.consumer_supplies = &supply_map;
   165	
   166		snprintf(int3472->regulator.regulator_name,
   167			 sizeof(int3472->regulator.regulator_name), "%s-regulator",
   168			 acpi_dev_name(int3472->adev));
   169		snprintf(int3472->regulator.supply_name,
   170			 GPIO_REGULATOR_SUPPLY_NAME_LENGTH, "supply-0");
   171	
   172		int3472->regulator.rdesc = INT3472_REGULATOR(
   173							int3472->regulator.regulator_name,
   174							int3472->regulator.supply_name,
   175							&int3472_gpio_regulator_ops);
   176	
   177		int3472->regulator.gpio = acpi_get_and_request_gpiod(path, agpio->pin_table[0],
   178								     "int3472,regulator");
   179		if (IS_ERR(int3472->regulator.gpio)) {
   180			dev_err(int3472->dev, "Failed to get regulator GPIO line\n");
   181			return PTR_ERR(int3472->regulator.gpio);
   182		}
   183	
   184		cfg.dev = &int3472->adev->dev;
   185		cfg.init_data = &init_data;
   186		cfg.ena_gpiod = int3472->regulator.gpio;
   187	
 > 188		int3472->regulator.rdev = regulator_register(int3742->dev,
   189							     &int3472->regulator.rdesc,
   190							     &cfg);
   191		if (IS_ERR(int3472->regulator.rdev)) {
   192			ret = PTR_ERR(int3472->regulator.rdev);
   193			goto err_free_gpio;
   194		}
   195	
   196		return 0;
   197	
   198	err_free_gpio:
   199		gpiod_put(int3472->regulator.gpio);
   200	
   201		return ret;
   202	}
   203	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (290230 bytes)