linux-kernel - Re: [PATCH] hwmon/coretemp: Simplify platform device antics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6fd52cbe-4cb0-d7a2-9f55-1e56c07843fe@leemhuis.info>
Date:   Tue, 6 Dec 2022 06:54:39 +0100
From:   Thorsten Leemhuis <regressions@...mhuis.info>
To:     Robin Murphy <robin.murphy@....com>,
        janusz.krzysztofik@...ux.intel.com
Cc:     fenghua.yu@...el.com, jdelvare@...e.com,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
        iommu@...ts.linux.dev, lucas.demarchi@...el.com,
        Guenter Roeck <linux@...ck-us.net>,
        "regressions@...ts.linux.dev" <regressions@...ts.linux.dev>
Subject: Re: [PATCH] hwmon/coretemp: Simplify platform device antics

On 01.12.22 16:02, Thorsten Leemhuis wrote:
> Hi, this is your Linux kernel regression tracker. I wondered what
> happened to this regression fix, as things looks stalled from here --
> but maybe I'm missing something.

This still looks stalled; hope someone will tell me if I missed any
progress.

> On 11.11.22 22:37, Guenter Roeck wrote:
>> On Thu, Nov 10, 2022 at 04:20:25PM +0000, Robin Murphy wrote:
>>> Coretemp's vestigial platform driver is odd. All the real work is done
>>> globally by the initcall and CPU hotplug notifiers, while the "driver"
>>> effectively just wraps an allocation and the registration of the hwmon
>>> interface in a long-winded round-trip through the driver core. The whole
>>> logic of dynamically creating and destroying platform devices to bring
>>> the interfaces up and down is fatally flawed right away, since it
>>> notifier from a platform bus notifier.
>> [...]
>>> I haven't been able to fully test hotplug since I only have a
>>> single-socket Intel system to hand.
>> Someone with access to hardware will have to validate this.
> That afaics has happened.
> 
>> For both subject and description, please avoid terms like "antics",
>> "odd", or "questionable". Please describe the problem in neutral terms.
> Robin, did you take care of that?

Robin, are you busy, or is there some other reason why this regression
fix afaics isn't making any progress?

Janusz Krzysztofik, as you seemed to care: if you have a minute and
Robin doesn't show up within a day or wo, could you maybe improve
subject and description to make Guenter happy?

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

P.S.: As the Linux kernel's regression tracker I deal with a lot of
reports and sometimes miss something important when writing mails like
this. If that's the case here, don't hesitate to tell me in a public
reply, it's in everyone's interest to set the public record straight.

#regzbot poke