linux-kernel - Re: [PATCH -next V8 00/14] riscv: Add GENERIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJF2gTSgvKV3Oh6t2dpbJGnt3cDZU14Qk_CxKPMXmEmgvMg8-Q@mail.gmail.com>
Date:   Tue, 6 Dec 2022 14:12:54 +0800
From:   Guo Ren <guoren@...nel.org>
To:     Björn Töpel <bjorn@...nel.org>
Cc:     arnd@...db.de, palmer@...osinc.com, tglx@...utronix.de,
        peterz@...radead.org, luto@...nel.org, conor.dooley@...rochip.com,
        heiko@...ech.de, jszhang@...nel.org, lazyparser@...il.com,
        falcon@...ylab.org, chenhuacai@...nel.org, apatel@...tanamicro.com,
        atishp@...shpatra.org, palmer@...belt.com,
        paul.walmsley@...ive.com, mark.rutland@....com,
        zouyipeng@...wei.com, bigeasy@...utronix.de,
        David.Laight@...lab.com, chenzhongjin@...wei.com,
        greentime.hu@...ive.com, andy.chiu@...ive.com,
        linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-riscv@...ts.infradead.org, Guo Ren <guoren@...ux.alibaba.com>
Subject: Re: [PATCH -next V8 00/14] riscv: Add GENERIC_ENTRY support and
 related features

On Mon, Dec 5, 2022 at 5:46 PM Björn Töpel <bjorn@...nel.org> wrote:
>
> guoren@...nel.org writes:
>
> > From: Guo Ren <guoren@...ux.alibaba.com>
> >
> > The patches convert riscv to use the generic entry infrastructure from
> > kernel/entry/*. Additionally, add independent irq stacks (IRQ_STACKS)
> > for percpu to prevent kernel stack overflows. Add generic_entry based
> > STACKLEAK support. Some optimization for entry.S with new .macro and
> > merge ret_from_kernel_thread into ret_from_fork.
> >
> > We have tested it with rv64, rv32, rv64 + 32rootfs, all are passed.
> >
> > You can directly try it with:
> > [1] https://github.com/guoren83/linux/tree/generic_entry_v8
>
> Guo, this is a really nice work, and I'm looking forward having generic
> entry support for RV. However, there are many patches in this series
> that really shouldn't be part of the series.
>
> Patch 2, 3, 4, and 10 should defintely be pulled out.
Okay.

>
> I'm not sure 7, 8, and 9 belong to series, as it's really a separate
> feature.
The separate irq/softirq stack patches dpend on generic_entry tightly,
so I recommand put them together.

>
> Dito for patch 11, it just makes the series harder to review.
The 11 is not so necessary as above, I would remove it from this
series. And send it again after generic_entry merged.

>
> For GENERIC_ENTRY support only patch 1, 5, 6, 12, 13, and 14, really
> required. The others are unrelated.
Thx for the reminder; I will re-organize them.

>
>
> Thanks,
> Björn



-- 
Best Regards
 Guo Ren