linux-kernel - Re: [PATCH v4,1/3] media: dt-bindings: media: mediatek: vcodec: adapt to the 'clock-names' of different platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <71003e4babe09bb7a5448bd7d0d5a987c9eb9c08.camel@mediatek.com>
Date:   Tue, 6 Dec 2022 06:43:54 +0000
From:   Yunfei Dong (董云飞) 
        <Yunfei.Dong@...iatek.com>
To:     "robh@...nel.org" <robh@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        Tiffany Lin (林慧珊) 
        <tiffany.lin@...iatek.com>,
        "wenst@...omium.org" <wenst@...omium.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "stevecho@...omium.org" <stevecho@...omium.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        Project_Global_Chrome_Upstream_Group 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        "hsinyi@...omium.org" <hsinyi@...omium.org>,
        "benjamin.gaignard@...labora.com" <benjamin.gaignard@...labora.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v4,1/3] media: dt-bindings: media: mediatek: vcodec: adapt
 to the 'clock-names' of different platforms

Hi Rob,

Thanks for your suggestion.

On Mon, 2022-12-05 at 11:54 -0600, Rob Herring wrote:
> On Fri, Dec 02, 2022 at 11:44:48AM +0800, Yunfei Dong wrote:
> > mt8195 and mt8192 have different clock numbers, separate 'clock-
> > names'
> > according to compatible name.
> > 
> > Signed-off-by: Yunfei Dong <yunfei.dong@...iatek.com>
> > ---
> > compared with v3:
> > - rewrite clock-names according to different platforms.
> > 
> > Reference series:
> > [1]: v5 of this series is presend by Allen-KH Cheng.
> >      message-id: 20221128143832.25584-4-allen-kh.cheng@...iatek.com
> > ---
> >  .../media/mediatek,vcodec-subdev-decoder.yaml | 41
> > ++++++++++++++++---
> >  1 file changed, 35 insertions(+), 6 deletions(-)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-
> > decoder.yaml
> > b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-
> > decoder.yaml
> > index 7c5b4a91c59b..a08b2c814f40 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > subdev-decoder.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > subdev-decoder.yaml
> > @@ -110,15 +110,12 @@ patternProperties:
> >            Refer to bindings/iommu/mediatek,iommu.yaml.
> >  
> >        clocks:
> > +        minItems: 1
> 
> Why 1? Looks like it should be 4 or 5 clocks.
> 
Yes, I should write this vale to 4, will change it again if 1 is used
in the future.

Best regards,
Yunfei Dong
> >          maxItems: 5
> >  
> >        clock-names:
> > -        items:
> > -          - const: sel
> > -          - const: soc-vdec
> > -          - const: soc-lat
> > -          - const: vdec
> > -          - const: top
> > +        minItems: 1
> > +        maxItems: 5
> >  
> >        assigned-clocks:
> >          maxItems: 1
> > @@ -159,6 +156,38 @@ then:
> >    required:
> >      - interrupts
> >  
> > +allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - mediatek,mt8192-vcodec-dec
> > +    then:
> > +      properties:
> > +        clock-names:
> > +          items:
> > +            - const: sel
> > +            - const: soc-vdec
> > +            - const: soc-lat
> > +            - const: vdec
> > +            - const: top
> > +
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - mediatek,mt8195-vcodec-dec
> > +    then:
> > +      properties:
> > +        clock-names:
> > +          items:
> > +            - const: sel
> > +            - const: vdec
> > +            - const: lat
> > +            - const: top
> > +
> >  additionalProperties: false
> >  
> >  examples:
> > -- 
> > 2.18.0
> > 
> >