[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <14e5c4e4-30dd-8efd-81e4-d680664ab04a@linaro.org>
Date: Tue, 6 Dec 2022 10:41:13 +0100
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Carlo Caione <ccaione@...libre.com>,
Daniel Vetter <daniel@...ll.ch>,
Jerome Brunet <jbrunet@...libre.com>,
David Airlie <airlied@...il.com>,
Kamlesh Gurudasani <kamlesh.gurudasani@...il.com>,
Mark Brown <broonie@...nel.org>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
Kevin Hilman <khilman@...libre.com>
Cc: linux-arm-kernel@...ts.infradead.org,
dri-devel@...ts.freedesktop.org, linux-amlogic@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] drm/tiny: ili9486: remove conflicting framebuffers
Hi Carlo,
On 06/12/2022 09:34, Carlo Caione wrote:
> For platforms using simplefb / efifb, call
> drm_aperture_remove_framebuffers() to remove the conflicting
> framebuffer.
Conflicting framebuffer on the SPI display ? How is that possible ?
The meson_drm should already do this, no ?
Neil
>
> Signed-off-by: Carlo Caione <ccaione@...libre.com>
> ---
> drivers/gpu/drm/tiny/ili9486.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/tiny/ili9486.c b/drivers/gpu/drm/tiny/ili9486.c
> index 14a9e6ad2d15..6fd4d42437fd 100644
> --- a/drivers/gpu/drm/tiny/ili9486.c
> +++ b/drivers/gpu/drm/tiny/ili9486.c
> @@ -14,6 +14,7 @@
>
> #include <video/mipi_display.h>
>
> +#include <drm/drm_aperture.h>
> #include <drm/drm_atomic_helper.h>
> #include <drm/drm_drv.h>
> #include <drm/drm_fb_helper.h>
> @@ -238,6 +239,10 @@ static int ili9486_probe(struct spi_device *spi)
> if (ret)
> return ret;
>
> + ret = drm_aperture_remove_framebuffers(false, &ili9486_driver);
> + if (ret)
> + return ret;
> +
> drm_mode_config_reset(drm);
>
> ret = drm_dev_register(drm, 0);
>
Powered by blists - more mailing lists