linux-kernel - Re: [PATCH] [PATCH v7 net-next] net: openvswitch: Add support to count upcall packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y48RV9j4WRUcsuYV@unreal>
Date:   Tue, 6 Dec 2022 11:54:31 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Eelco Chaudron <echaudro@...hat.com>
Cc:     wangchuanlei <wangchuanlei@...pur.com>, alexandr.lobakin@...el.com,
        pabeni@...hat.com, pshelar@....org, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, wangpeihui@...pur.com,
        netdev@...r.kernel.org, dev@...nvswitch.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [PATCH v7 net-next] net: openvswitch: Add support to
 count upcall packets

On Tue, Dec 06, 2022 at 09:12:01AM +0100, Eelco Chaudron wrote:
> 
> 
> On 5 Dec 2022, at 4:00, wangchuanlei wrote:
> 
> > Add support to count upall packets, when kmod of openvswitch
> > upcall to userspace , here count the number of packets for
> > upcall succeed and failed, which is a better way to see how
> > many packets upcalled to userspace(ovs-vswitchd) on every
> > interfaces.
> 
> Thanks for including my suggestions, one more comment below.
> 
> > Here modify format of code used by comments of v6.
> >
> > Changes since v4 & v5 & v6:
> > - optimize the function used by comments
> >
> > Changes since v3:
> > - use nested NLA_NESTED attribute in netlink message
> >
> > Changes since v2:
> > - add count of upcall failed packets
> >
> > Changes since v1:
> > - add count of upcall succeed packets

Please put changelog after "---". It doesn't belong to commit message.

Thanks

> >
> > Signed-off-by: wangchuanlei <wangchuanlei@...pur.com>
> > ---