[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y48XUjSMWVvohIy3@zn.tnic>
Date: Tue, 6 Dec 2022 11:20:02 +0100
From: Borislav Petkov <bp@...en8.de>
To: stuart hayes <stuart.w.hayes@...il.com>
Cc: "Rafael J . Wysocki" <rafael@...nel.org>,
Viresh Kumar <viresh.kumar@...aro.org>,
Kyle Meyer <kyle.meyer@....com>, linux-pm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: acpi: Only set boost MSRs on supported CPUs
On Mon, Dec 05, 2022 at 12:07:05PM -0600, stuart hayes wrote:
>
>
> On 12/5/2022 11:57 AM, Stuart Hayes wrote:
> > Stop trying to set boost MSRs on CPUs that don't support boost.
> >
> > This corrects a bug in the recent patch "Defer setting boost MSRs".
> >
> > Signed-off-by: Stuart Hayes <stuart.w.hayes@...il.com>
> > ---
> > drivers/cpufreq/acpi-cpufreq.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> > index bb58175a8d40..a7c5e312340e 100644
> > --- a/drivers/cpufreq/acpi-cpufreq.c
> > +++ b/drivers/cpufreq/acpi-cpufreq.c
> > @@ -888,7 +888,8 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
> > if (perf->states[0].core_frequency * 1000 != freq_table[0].frequency)
> > pr_warn(FW_WARN "P-state 0 is not max freq\n");
> > - set_boost(policy, acpi_cpufreq_driver.boost_enabled);
> > + if (acpi_cpufreq_driver.set_boost)
> > + set_boost(policy, acpi_cpufreq_driver.boost_enabled);
> > return result;
>
> My apologies--adding Boris, I forgot to put him on the "to" list.
Yap, that does it.
Reported-by: Borislav Petkov (AMD) <bp@...en8.de>
Tested-by: Borislav Petkov (AMD) <bp@...en8.de>
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
Powered by blists - more mailing lists