linux-kernel - Re: [PATCH] mmc: sdhci-brcmstb: Resolve "unused" warnings with CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Dec 2022 16:10:19 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Brian Norris <briannorris@...omium.org>,
        Ulf Hansson <ulf.hansson@...aro.org>
Cc:     linux-mmc@...r.kernel.org, Florian Fainelli <f.fainelli@...il.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Al Cooper <alcooperx@...il.com>, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] mmc: sdhci-brcmstb: Resolve "unused" warnings with
 CONFIG_OF=n

On 12/5/22 16:04, Brian Norris wrote:
> With W=1, we can see this gcc warning:
> 
> drivers/mmc/host/sdhci-brcmstb.c:182:34: warning: ‘sdhci_brcm_of_match’ defined but not used [-Wunused-const-variable=]
>    182 | static const struct of_device_id sdhci_brcm_of_match[] = {
>        |                                  ^~~~~~~~~~~~~~~~~~~
> 
> Rather than play around more with #ifdef's, the simplest solution is to
> just mark this __maybe_unused.
> 
> Fixes: 1fad8422c989 ("mmc: sdhci-brcmstb: Allow building with COMPILE_TEST")
> Reported-by: kernel test robot <lkp@...el.com>
> Link: https://lore.kernel.org/all/202212060700.NjMecjxS-lkp@intel.com/
> Signed-off-by: Brian Norris <briannorris@...omium.org>

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian