linux-kernel - Re: [Patch net-next v2 01/13] net: dsa: microchip: ptp: add the posix clock support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5892889.lOV4Wx5bFT@n95hx1g2>
Date:   Tue, 6 Dec 2022 11:37:26 +0100
From:   Christian Eggers <ceggers@...i.de>
To:     <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        Arun Ramadoss <arun.ramadoss@...rochip.com>
CC:     <woojung.huh@...rochip.com>, <UNGLinuxDriver@...rochip.com>,
        <andrew@...n.ch>, <vivien.didelot@...il.com>,
        <f.fainelli@...il.com>, <olteanv@...il.com>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <linux@...linux.org.uk>, <Tristram.Ha@...rochip.com>,
        <richardcochran@...il.com>
Subject: Re: [Patch net-next v2 01/13] net: dsa: microchip: ptp: add the posix clock support

Hi Arun,

On Tuesday, 6 December 2022, 10:14:16 CET, Arun Ramadoss wrote:
> From: Christian Eggers <ceggers@...i.de>
> 
> This patch implement routines (adjfine, adjtime, gettime and settime)
> for manipulating the chip's PTP clock. It registers the ptp caps
> to posix clock register.
> 
> Signed-off-by: Christian Eggers <ceggers@...i.de>
> Co-developed-by: Arun Ramadoss <arun.ramadoss@...rochip.com>
> Signed-off-by: Arun Ramadoss <arun.ramadoss@...rochip.com>
> 
> ---
> v1 -> v2
> - added arri in copyright message
> - Deleted setting 8021_1as bit and added P2P bit in ksz_ptp_clock_register()

did I miss the discussion about this change? I thought that the first goal is
to use KSZ switches as a boundary clock which implies using the 802.1AS feature.

Using the KSZ in P2P transparent clock mode IMHO requires writing the peer delays
into switch registers (which needs to be implemented in a companion 
application/script for ptp4p).

As far as I remember, there is also no support using ptp4l with 1-step transparent
clock switches.

regards
Christian