linux-kernel - Re: net/mptcp/pm_netlink.c:1169 mptcp_pm_parse_pm_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3b6b27ec-e478-1e71-a84e-e1177827d437@intel.com>
Date:   Tue, 6 Dec 2022 18:42:52 +0800
From:   "Chen, Rong A" <rong.a.chen@...el.com>
To:     Dan Carpenter <error27@...il.com>,
        Mat Martineau <mathew.j.martineau@...ux.intel.com>,
        lkp@...el.com
Cc:     oe-kbuild@...ts.linux.dev, Florian Westphal <fw@...len.de>,
        oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        mptcp@...ts.linux.dev,
        Matthieu Baerts <matthieu.baerts@...sares.net>
Subject: Re: net/mptcp/pm_netlink.c:1169 mptcp_pm_parse_pm_addr_attr() warn:
 missing error code? 'err'



On 12/3/2022 4:29 PM, Dan Carpenter wrote:
> On Fri, Dec 02, 2022 at 03:38:01PM -0800, Mat Martineau wrote:
>>> 01cacb00b35cb6 Paolo Abeni      2020-03-27  1158  	/* no validation needed - was already done via nested policy */
>>> 01cacb00b35cb6 Paolo Abeni      2020-03-27  1159  	err = nla_parse_nested_deprecated(tb, MPTCP_PM_ADDR_ATTR_MAX, attr,
>>> 01cacb00b35cb6 Paolo Abeni      2020-03-27  1160  					  mptcp_pm_addr_policy, info->extack);
>>> 01cacb00b35cb6 Paolo Abeni      2020-03-27  1161  	if (err)
>>> 01cacb00b35cb6 Paolo Abeni      2020-03-27  1162  		return err;
>>> 01cacb00b35cb6 Paolo Abeni      2020-03-27  1163
>>> 982f17ba1a2534 Florian Westphal 2022-05-03  1164  	if (tb[MPTCP_PM_ADDR_ATTR_ID])
>>> 982f17ba1a2534 Florian Westphal 2022-05-03  1165  		addr->id = nla_get_u8(tb[MPTCP_PM_ADDR_ATTR_ID]);
>>> 982f17ba1a2534 Florian Westphal 2022-05-03  1166
>>> 01cacb00b35cb6 Paolo Abeni      2020-03-27  1167  	if (!tb[MPTCP_PM_ADDR_ATTR_FAMILY]) {
>>> 01cacb00b35cb6 Paolo Abeni      2020-03-27  1168  		if (!require_family)
>>> 982f17ba1a2534 Florian Westphal 2022-05-03 @1169  			return err;
>>>
>>> "err" is zero at this point.  Presumably a negative error code was
>>> intended.
>>
>> Hi Dan -
>>
>> The intended error code is 0 here: the return happens if no
>> MPTCP_PM_ADDR_ATTR_FAMILY value is present and require_family is false.
>>
>> It would be clearer to "return 0;", but the code is working as expected.
>>
>>
>> Could you be sure to cc mptcp@...ts.linux.dev and
>> matthieu.baerts@...sares.net for future MPTCP issues?

Hi Mat,

Sorry for the delay, we'll cc you and the mailing list in the future.

Best Regards,
Rong Chen

> 
> These emails are automatically generated by the kbuild team.  I don't
> know what kind of heuristics they use...  I've put them on the To
> header.  There is probably a reason why they don't just use
> get_maintainer.pl...
> 
> regards,
> dan carpenter
> 
>