[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAPTae5KvmBXJrYByttNz4mmubfP9M_jAJh8Gx=5hgn2PajBuVg@mail.gmail.com>
Date: Mon, 5 Dec 2022 17:33:15 -0800
From: Badhri Jagan Sridharan <badhri@...gle.com>
To: Guenter Roeck <linux@...ck-us.net>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
Kyle Tso <kyletso@...gle.com>
Subject: Re: [PATCH v3 3/3] usb: typec: maxim_contaminant: Implement
check_contaminant callback
Fixing both the comments in version 4 of the patchset. Thanks !
On Sun, Dec 4, 2022 at 7:57 AM Guenter Roeck <linux@...ck-us.net> wrote:
>
> On Sun, Dec 04, 2022 at 10:43:02AM +0100, Greg Kroah-Hartman wrote:
> > On Sun, Dec 04, 2022 at 12:48:44AM -0800, Badhri Jagan Sridharan wrote:
> > > +EXPORT_SYMBOL_GPL(is_contaminant);
> >
> > Sorry, but this is a horrible name for the kernel global namespace.
> > Please properly prefix it to show exactly what subsystem this is from.
> >
>
> I don't think this needs to be exported either.
>
> Guenter
Powered by blists - more mailing lists