linux-kernel - Re: [PATCH] trace: Fix some checker warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 6 Dec 2022 22:59:23 +0900
From:   Masami Hiramatsu (Google) <mhiramat@...nel.org>
To:     David Howells <dhowells@...hat.com>
Cc:     rostedt@...dmis.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] trace: Fix some checker warnings

On Mon, 05 Dec 2022 10:29:46 +0000
David Howells <dhowells@...hat.com> wrote:

> Btw, do you know how to deal with:
> 
> 	add_ftrace_export(struct trace_export **list, struct trace_export *export)
> 
> being called by:
> 
> 	add_ftrace_export(&ftrace_exports_list, export);
> 
> but ftrace_exports_list has an __rcu annotation, so the list argument in the
> former should have an __rcu annotation in it somewhere too.

Can't you just add __rcu to the 'list' argument?

> 
> OTOH - there's only one user of add_trace_export() and add_ftrace_export(), so
> can they be collapsed into register_ftrace_export()?

Steve, do you have any idea?

Thanks,

> 
> David
> 


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>