linux-kernel - [PATCH v6 0/1] remoteproc: core: do pm relax when in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221206015957.2616-1-quic_aiquny@quicinc.com>
Date:   Tue, 6 Dec 2022 09:59:56 +0800
From:   Maria Yu <quic_aiquny@...cinc.com>
To:     <mathieu.poirier@...aro.org>, <andersson@...nel.org>,
        <linux-remoteproc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     Maria Yu <quic_aiquny@...cinc.com>, <quic_clew@...cinc.com>,
        <quic_mojha@...cinc.com>
Subject: [PATCH v6 0/1] remoteproc: core: do pm relax when in

If the remote processor is offline, no need to recover anything, and
pm_relax is needed to be called.

summary from some discussion points:

pm_stay_awake() is needed to stop and reverse the suspend process that
is currently underway.

RPROC_OFFLINE state indicate there is no recovery process
is in progress and no chance to do the pm_relax.
Because when recovering from crash, rproc->lock is held and
state is RPROC_CRASHED -> RPROC_OFFLINE -> RPROC_RUNNING,
and then unlock rproc->lock.
When the state is in RPROC_OFFLINE it means separate request
of rproc_stop was done and no need to hold the wakeup source
in crash handler to recover any more.

Changelog
===
V6
---
Address the comments.
Drop the allocate ordered workqueue change.

V5
---
Use goto out instead of directly call pm_relax and return. Suggested by
Mathieu.
Add new change with allocate ordered workqueue for allow only 1 active
work.

V4
---
Add pm relax when in RPROC_OFFLINE.

previous discussion here:
[1] https://lore.kernel.org/lkml/1bcd3fe8-f68d-ea7f-c0f9-68771e3421d5@quicinc.com/
[2] https://lore.kernel.org/linux-remoteproc/20221202094532.2925-1-quic_aiquny@quicinc.com/T/#t

Maria Yu (1):
  remoteproc: core: do pm_relax when in RPROC_OFFLINE state

 drivers/remoteproc/remoteproc_core.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

-- 
2.17.1