lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Y49byhJ/Yn5/I28d@smile.fi.intel.com>
Date:   Tue, 6 Dec 2022 17:12:10 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     ye.xingchen@....com.cn
Cc:     jic23@...nel.org, michael.hennerich@...log.com, lars@...afoo.de,
        u.kleine-koenig@...gutronix.de, jk@...econstruct.com.au,
        wsa@...nel.org, ddrokosov@...rdevices.ru, hdegoede@...hat.com,
        haibo.chen@....com, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: accel: Convert to use sysfs_emit_at() API

On Tue, Dec 06, 2022 at 07:53:20PM +0800, ye.xingchen@....com.cn wrote:
> From: ye xingchen <ye.xingchen@....com.cn>
> 
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.

Please split on per device driver basis (3 patches here).

The code looks fine to me, thanks.

-- 
With Best Regards,
Andy Shevchenko


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ