linux-kernel - Re: [PATCH] powerpc/ftrace: fix syscall tracing on PPC64_ELF_ABI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61d98db6-68b3-1a5c-f59b-592048c742fd@csgroup.eu>
Date:   Wed, 7 Dec 2022 16:26:54 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Michael Jeanson <mjeanson@...icios.com>,
        Steven Rostedt <rostedt@...dmis.org>
CC:     "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Nicholas Piggin <npiggin@...il.com>,
        Michal Suchanek <msuchanek@...e.de>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] powerpc/ftrace: fix syscall tracing on PPC64_ELF_ABI_V1



Le 07/12/2022 à 16:18, Mathieu Desnoyers a écrit :
> On 2022-12-06 21:09, Michael Ellerman wrote:
>> Mathieu Desnoyers <mathieu.desnoyers@...icios.com> writes:
>>> On 2022-12-05 17:50, Michael Ellerman wrote:
>>> IMHO the second option would be better because it does not increase the
>>> kernel image size as much as KALLSYMS_ALL.
>>
>> Yes I agree.
>>
>> Even if that did break something, any breakage would be limited to
>> arches which uses function descriptors, which are now all rare.
> 
> Yes, it would only impact those arches using function descriptors, which 
> are broken today with respect to system call tracing. Are you aware of 
> other architectures other than PPC64 ELF ABI v1 supported by the Linux 
> kernel that use function descriptors ?

$ git grep "select HAVE_FUNCTION_DESCRIPTORS" arch/
arch/ia64/Kconfig:      select HAVE_FUNCTION_DESCRIPTORS
arch/parisc/Kconfig:    select HAVE_FUNCTION_DESCRIPTORS if 64BIT
arch/powerpc/Kconfig:   select HAVE_FUNCTION_DESCRIPTORS        if 
PPC64_ELF_ABI_V1


Christophe