linux-kernel - Re: [PATCH] ASoc: SOF: Fix sof-audio-pci-intel-tgl shutdown timeout during hibernation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202212080011.ZwHXCjyY-lkp@intel.com>
Date:   Thu, 8 Dec 2022 00:31:34 +0800
From:   kernel test robot <lkp@...el.com>
To:     Zhen Ni <nizhen@...ontech.com>, perex@...ex.cz, tiwai@...e.com
Cc:     oe-kbuild-all@...ts.linux.dev, Zhen Ni <nizhen@...ontech.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoc: SOF: Fix sof-audio-pci-intel-tgl shutdown timeout
 during hibernation

Hi Zhen,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tiwai-sound/for-next]
[also build test ERROR on tiwai-sound/for-linus linus/master v6.1-rc8 next-20221207]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Zhen-Ni/ASoc-SOF-Fix-sof-audio-pci-intel-tgl-shutdown-timeout-during-hibernation/20221207-182430
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
patch link:    https://lore.kernel.org/r/20221207102229.25962-1-nizhen%40uniontech.com
patch subject: [PATCH] ASoc: SOF: Fix sof-audio-pci-intel-tgl shutdown timeout during hibernation
config: i386-randconfig-a001
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/38abc03ca81d8486e02a58fa505b25777b03bcdd
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Zhen-Ni/ASoc-SOF-Fix-sof-audio-pci-intel-tgl-shutdown-timeout-during-hibernation/20221207-182430
        git checkout 38abc03ca81d8486e02a58fa505b25777b03bcdd
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   sound/core/init.c: In function 'snd_card_free':
>> sound/core/init.c:663:71: error: expected ';' before 'return'
     663 |         wait_for_completion_timeout(&released, msecs_to_jiffies(2000))
         |                                                                       ^
         |                                                                       ;
     664 | 
     665 |         return 0;
         |         ~~~~~~                                                         
   sound/core/init.c:666:1: error: control reaches end of non-void function [-Werror=return-type]
     666 | }
         | ^
   cc1: some warnings being treated as errors


vim +663 sound/core/init.c

   630	
   631	/**
   632	 * snd_card_free - frees given soundcard structure
   633	 * @card: soundcard structure
   634	 *
   635	 * This function releases the soundcard structure and the all assigned
   636	 * devices automatically.  That is, you don't have to release the devices
   637	 * by yourself.
   638	 *
   639	 * This function waits until the all resources are properly released.
   640	 *
   641	 * Return: Zero. Frees all associated devices and frees the control
   642	 * interface associated to given soundcard.
   643	 */
   644	int snd_card_free(struct snd_card *card)
   645	{
   646		DECLARE_COMPLETION_ONSTACK(released);
   647		int ret;
   648	
   649		/* The call of snd_card_free() is allowed from various code paths;
   650		 * a manual call from the driver and the call via devres_free, and
   651		 * we need to avoid double-free. Moreover, the release via devres
   652		 * may call snd_card_free() twice due to its nature, we need to have
   653		 * the check here at the beginning.
   654		 */
   655		if (card->releasing)
   656			return 0;
   657	
   658		card->release_completion = &released;
   659		ret = snd_card_free_when_closed(card);
   660		if (ret)
   661			return ret;
   662		/* wait, until all devices are ready for the free operation */
 > 663		wait_for_completion_timeout(&released, msecs_to_jiffies(2000))
   664	
   665		return 0;
   666	}
   667	EXPORT_SYMBOL(snd_card_free);
   668	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (153024 bytes)