[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221206175557.1cbd3baa@kernel.org>
Date: Tue, 6 Dec 2022 17:55:57 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Kees Cook <keescook@...omium.org>
Cc: "David S. Miller" <davem@...emloft.net>,
syzbot+fda18eaa8c12534ccb3b@...kaller.appspotmail.com,
Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>,
Pavel Begunkov <asml.silence@...il.com>,
pepsipu <soopthegoop@...il.com>,
Vlastimil Babka <vbabka@...e.cz>,
kasan-dev <kasan-dev@...glegroups.com>,
Andrii Nakryiko <andrii@...nel.org>, ast@...nel.org,
bpf <bpf@...r.kernel.org>,
Daniel Borkmann <daniel@...earbox.net>,
Hao Luo <haoluo@...gle.com>,
Jesper Dangaard Brouer <hawk@...nel.org>,
John Fastabend <john.fastabend@...il.com>, jolsa@...nel.org,
KP Singh <kpsingh@...nel.org>, martin.lau@...ux.dev,
Stanislav Fomichev <sdf@...gle.com>, song@...nel.org,
Yonghong Song <yhs@...com>, netdev@...r.kernel.org,
LKML <linux-kernel@...r.kernel.org>,
Menglong Dong <imagedong@...cent.com>,
David Ahern <dsahern@...nel.org>,
Martin KaFai Lau <kafai@...com>,
Luiz Augusto von Dentz <luiz.von.dentz@...el.com>,
Richard Gobert <richardbgobert@...il.com>,
Andrey Konovalov <andreyknvl@...il.com>,
David Rientjes <rientjes@...gle.com>,
linux-hardening@...r.kernel.org
Subject: Re: [PATCH] skbuff: Reallocate to ksize() in __build_skb_around()
On Tue, 6 Dec 2022 15:17:14 -0800 Kees Cook wrote:
> - unsigned int size = frag_size ? : ksize(data);
> + unsigned int size = frag_size;
> +
> + /* When frag_size == 0, the buffer came from kmalloc, so we
> + * must find its true allocation size (and grow it to match).
> + */
> + if (unlikely(size == 0)) {
> + void *resized;
> +
> + size = ksize(data);
> + /* krealloc() will immediate return "data" when
> + * "ksize(data)" is requested: it is the existing upper
> + * bounds. As a result, GFP_ATOMIC will be ignored.
> + */
> + resized = krealloc(data, size, GFP_ATOMIC);
> + if (WARN_ON(resized != data))
> + data = resized;
> + }
>
Aammgh. build_skb(0) is plain silly, AFAIK. The performance hit of
using kmalloc()'ed heads is large because GRO can't free the metadata.
So we end up carrying per-MTU skbs across to the application and then
freeing them one by one. With pages we just aggregate up to 64k of data
in a single skb.
I can only grep out 3 cases of build_skb(.. 0), could we instead
convert them into a new build_skb_slab(), and handle all the silliness
in such a new helper? That'd be a win both for the memory safety and one
fewer branch for the fast path.
I think it's worth doing, so LMK if you're okay to do this extra work,
otherwise I can help (unless e.g. Eric tells me I'm wrong..).
Powered by blists - more mailing lists