linux-kernel - Re: [PATCH v4 0/6] Add Auxiliary driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 7 Dec 2022 09:49:24 -0800
From:   Ajit Khaparde <ajit.khaparde@...adcom.com>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     andrew.gospodarek@...adcom.com, davem@...emloft.net,
        edumazet@...gle.com, jgg@...pe.ca, kuba@...nel.org,
        linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org,
        michael.chan@...adcom.com, netdev@...r.kernel.org,
        pabeni@...hat.com, selvin.xavier@...adcom.com
Subject: Re: [PATCH v4 0/6] Add Auxiliary driver support

On Tue, Nov 29, 2022 at 1:13 AM Leon Romanovsky <leon@...nel.org> wrote:
>
> On Mon, Nov 28, 2022 at 06:01:13PM -0800, Ajit Khaparde wrote:
> > On Tue, Nov 22, 2022 at 10:59 PM Leon Romanovsky <leon@...nel.org> wrote:
> > >
::: snip :::
> >
> > >
> > > > So we are trying to call the
> > > > bnxt_re_sriov_config in the context of handling the PF's
> > > > sriov_configure implementation.  Having the ulp_ops is allowing us to
> > > > avoid resource wastage and assumptions in the bnxt_re driver.
> > >
> > > To which resource wastage are you referring?
> > Essentially the PF driver reserves a set of above resources for the PF,
> > and divides the remaining resources among the VFs.
> > If the calculation is based on sriov_totalvfs instead of sriov_numvfs,
> > there can be a difference in the resources provisioned for a VF.
> > And that is because a user may create a subset of VFs instead of the
> > total VFs allowed in the PCI SR-IOV capability register.
> > I was referring to the resource wastage in that deployment scenario.
>
> It is ok, set all needed limits in bnxt_en. You don't need to call to
> bnxt_re for that.
Thanks. We have removed the sriov_config callback.
I will send the fresh patchset in a few minutes.

>
> >
> > Thanks
> > Ajit
> >
> > >
> > > There are no differences if same limits will be in bnxt_en driver when
> > > RDMA bnxt device is created or in bnxt_re which will be called once RDMA
> > > device is created.
> > >
> > > Thanks
> > >
> > > >
> > > > ::snip::
> > >
> > >
>
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4218 bytes)