linux-kernel - Re: [PATCH v1 2/2] leds: add aw20xx driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y5DuAVKu/nSXMkUa@duo.ucw.cz>
Date:   Wed, 7 Dec 2022 20:48:17 +0100
From:   Pavel Machek <pavel@....cz>
To:     Martin Kurbanov <MMKurbanov@...rdevices.ru>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jonathan Corbet <corbet@....net>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        kernel <kernel@...rdevices.ru>
Subject: Re: [PATCH v1 2/2] leds: add aw20xx driver

On Mon 2022-11-28 17:45:22, Martin Kurbanov wrote:
> On 25.11.2022 11:19, Krzysztof Kozlowski wrote:
> >> +    $ ls -l /sys/bus/i2c/devices/xxxx/pattern0/
> >> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 clear_leds
> >> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 fall_time
> >> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 loop_begin
> >> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 loop_end_on
> >> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 max_breathing_level
> >> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 min_breathing_level
> >> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 mode
> >> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 off_time
> >> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 on_time
> >> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 ramp
> >> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 repeat
> >> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 rise_time
> >> +    -r--r--r--    1 root     root          4096 Jan  1 00:00 running
> >> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 select_leds
> >> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 start
> >> +    -rw-r--r--    1 root     root          4096 Jan  1 00:00 toggle
> > 
> > sysfs documentation goes to Documentation/ABI/
> 
> Should I add it to Documentation/ABI/testing/sysfs-class-led-driver-aw200xx?
> Is my understanding correct?
> Is KernelVersion parameter required?

You really should take a look at pattern trigger. You should probably
use same API as it does, perhaps documenting which patterns this
particular driver can do in hardware.

Best regards,
							Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)