linux-kernel - Re: [PATCH v10 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc1b64dc-938e-0bb2-ef28-c09c7ec17efd@linaro.org>
Date:   Wed, 7 Dec 2022 22:06:10 +0200
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Kuogee Hsieh <quic_khsieh@...cinc.com>,
        dri-devel@...ts.freedesktop.org, robdclark@...il.com,
        sean@...rly.run, swboyd@...omium.org, dianders@...omium.org,
        vkoul@...nel.org, daniel@...ll.ch, airlied@...ux.ie,
        agross@...nel.org, andersson@...nel.org,
        konrad.dybcio@...ainline.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, devicetree@...r.kernel.org,
        airlied@...il.com
Cc:     quic_abhinavk@...cinc.com, quic_sbillaka@...cinc.com,
        freedreno@...ts.freedesktop.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v10 2/5] dt-bindings: msm/dp: add data-lanes and
 link-frequencies property

On 07/12/2022 18:57, Kuogee Hsieh wrote:
> Add both data-lanes and link-frequencies property into endpoint
> 
> Changes in v7:
> -- split yaml out of dtsi patch
> -- link-frequencies from link rate to symbol rate
> -- deprecation of old data-lanes property
> 
> Changes in v8:
> -- correct Bjorn mail address to kernel.org
> 
> Changes in v10:
> -- add menu item to data-lanes and link-frequecnis
> 
> Signed-off-by: Kuogee Hsieh <quic_khsieh@...cinc.com>`
> ---
>   .../devicetree/bindings/display/msm/dp-controller.yaml      | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> index f2515af..c4a278f 100644
> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> @@ -81,6 +81,7 @@ properties:
>   
>     data-lanes:
>       $ref: /schemas/types.yaml#/definitions/uint32-array
> +    deprecated: true
>       minItems: 1
>       maxItems: 4
>       items:
> @@ -104,6 +105,15 @@ properties:
>         port@1:
>           $ref: /schemas/graph.yaml#/properties/port
>           description: Output endpoint of the controller
> +          data-lanes:
> +          $ref: /schemas/types.yaml#/definitions/uint32-array
> +          minItems: 1
> +          maxItems: 4
> +
> +          link-frequencies:
> +          $ref: /schemas/types.yaml#/definitions/uint64-array
> +          minItems: 1
> +          maxItems: 4

There is an issue here. You are describing the properties beneath the 
port@1, while in reality they are found beneath the endpoint node. See 
analogix,anx7625.yaml for a proper example.

>   
>   required:
>     - compatible
> @@ -193,6 +203,9 @@ examples:
>                   reg = <1>;
>                   endpoint {
>                       remote-endpoint = <&typec>;
> +                    data-lanes = <1 2>;
> +                    link-frequencies = /bits/ 64 <1620000000 2700000000
> +                                                  5400000000 8100000000>;
>                   };
>               };
>           };

-- 
With best wishes
Dmitry