lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 7 Dec 2022 14:27:52 -0800 From: Mike Kravetz <mike.kravetz@...cle.com> To: Peter Xu <peterx@...hat.com> Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org, Jann Horn <jannh@...gle.com>, Andrea Arcangeli <aarcange@...hat.com>, James Houghton <jthoughton@...gle.com>, Rik van Riel <riel@...riel.com>, Miaohe Lin <linmiaohe@...wei.com>, Nadav Amit <nadav.amit@...il.com>, John Hubbard <jhubbard@...dia.com>, David Hildenbrand <david@...hat.com>, Andrew Morton <akpm@...ux-foundation.org>, Muchun Song <songmuchun@...edance.com> Subject: Re: [PATCH v2 09/10] mm/hugetlb: Introduce hugetlb_walk() On 12/07/22 15:31, Peter Xu wrote: > huge_pte_offset() is the main walker function for hugetlb pgtables. The > name is not really representing what it does, though. > > Instead of renaming it, introduce a wrapper function called hugetlb_walk() > which will use huge_pte_offset() inside. Assert on the locks when walking > the pgtable. > > Note, the vma lock assertion will be a no-op for private mappings. > > Signed-off-by: Peter Xu <peterx@...hat.com> > --- > fs/hugetlbfs/inode.c | 4 +--- > fs/userfaultfd.c | 6 ++---- > include/linux/hugetlb.h | 39 +++++++++++++++++++++++++++++++++++++++ > mm/hugetlb.c | 32 +++++++++++++------------------- > mm/page_vma_mapped.c | 2 +- > mm/pagewalk.c | 4 +--- > 6 files changed, 57 insertions(+), 30 deletions(-) Thanks! I like the lockdep checks in hugetlb_walk. Reviewed-by: Mike Kravetz <mike.kravetz@...cle.com> -- Mike Kravetz
Powered by blists - more mailing lists