linux-kernel - Re: [PATCH] net: ipa: use sysfs_emit() to instead of scnprintf()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 6 Dec 2022 18:53:29 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Alex Elder <elder@...e.org>
Cc:     ye.xingchen@....com.cn, davem@...emloft.net, elder@...nel.org,
        edumazet@...gle.com, pabeni@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ipa: use sysfs_emit() to instead of scnprintf()

On Fri, 2 Dec 2022 16:20:16 -0600 Alex Elder wrote:
> On 12/2/22 2:42 AM, ye.xingchen@....com.cn wrote:
> > From: ye xingchen <ye.xingchen@....com.cn>
> > 
> > Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> > should only use sysfs_emit() or sysfs_emit_at() when formatting the
> > value to be returned to user space.  
> 
> The buffer passed is non-null and the existing code properly
> limits the buffer to PAGE_SIZE.
> 
> But... OK.
> 
> Reviewed-by: Alex Elder <elder@...aro.org>
> 

Thanks! 38db82e2940 in net-next.