linux-kernel - [PATCH] iio: light: tsl2772: Convert to use sysfs_emit()/sysfs_emit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 7 Dec 2022 15:46:47 +0800 (CST)
From:   <ye.xingchen@....com.cn>
To:     <andriy.shevchenko@...ux.intel.com>
Cc:     <jic23@...nel.org>, <lars@...afoo.de>,
        <u.kleine-koenig@...gutronix.de>, <gwendal@...omium.org>,
        <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: [PATCH] iio: light: tsl2772: Convert to use sysfs_emit()/sysfs_emit_at() APIs

From: ye xingchen <ye.xingchen@....com.cn>

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
---
 drivers/iio/light/tsl2772.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/iio/light/tsl2772.c b/drivers/iio/light/tsl2772.c
index ad50baa0202c..03cae6a536b4 100644
--- a/drivers/iio/light/tsl2772.c
+++ b/drivers/iio/light/tsl2772.c
@@ -927,7 +927,7 @@ static ssize_t in_illuminance0_target_input_show(struct device *dev,
 {
 	struct tsl2772_chip *chip = iio_priv(dev_to_iio_dev(dev));

-	return scnprintf(buf, PAGE_SIZE, "%d\n", chip->settings.als_cal_target);
+	return sysfs_emit(buf, "%d\n", chip->settings.als_cal_target);
 }

 static ssize_t in_illuminance0_target_input_store(struct device *dev,
@@ -981,9 +981,9 @@ static ssize_t in_illuminance0_lux_table_show(struct device *dev,
 	int offset = 0;

 	while (i < TSL2772_MAX_LUX_TABLE_SIZE) {
-		offset += scnprintf(buf + offset, PAGE_SIZE - offset, "%u,%u,",
-			chip->tsl2772_device_lux[i].ch0,
-			chip->tsl2772_device_lux[i].ch1);
+		offset += sysfs_emit_at(buf, offset, "%u,%u,",
+					chip->tsl2772_device_lux[i].ch0,
+					chip->tsl2772_device_lux[i].ch1);
 		if (chip->tsl2772_device_lux[i].ch0 == 0) {
 			/*
 			 * We just printed the first "0" entry.
@@ -995,7 +995,7 @@ static ssize_t in_illuminance0_lux_table_show(struct device *dev,
 		i++;
 	}

-	offset += scnprintf(buf + offset, PAGE_SIZE - offset, "\n");
+	offset += sysfs_emit_at(buf, offset, "\n");
 	return offset;
 }

-- 
2.25.1