linux-kernel - Re: [PATCH V5 0/2] Support VMCOREINFO export for RISCV64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y5BJ/EeBTEJK2QLF@spud>
Date:   Wed, 7 Dec 2022 08:08:28 +0000
From:   Conor Dooley <conor@...nel.org>
To:     Guo Ren <guoren@...nel.org>
Cc:     Palmer Dabbelt <palmer@...osinc.com>,
        Xianting Tian <xianting.tian@...ux.alibaba.com>,
        mick@....forth.gr, corbet@....net, alexandre.ghiti@...onical.com,
        vgoyal@...hat.com, bhe@...hat.com,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Conor Dooley <conor.dooley@...rochip.com>,
        bagasdotme@...il.com, dyoung@...hat.com,
        Palmer Dabbelt <palmer@...belt.com>, heiko@...ech.de,
        anup@...infault.org, aou@...s.berkeley.edu,
        hschauhan@...ltrace.org, yixun.lan@...il.com,
        kexec@...ts.infradead.org, heinrich.schuchardt@...onical.com,
        linux-doc@...r.kernel.org, crash-utility@...hat.com,
        linux-kernel@...r.kernel.org, k-hagio-ab@....com,
        linux-riscv@...ts.infradead.org
Subject: Re: [PATCH V5 0/2] Support VMCOREINFO export for RISCV64

On Wed, Dec 07, 2022 at 11:34:57AM +0800, Guo Ren wrote:
> On Wed, Dec 7, 2022 at 7:05 AM Conor Dooley <conor@...nel.org> wrote:
> >
> > Hey Palmer, Xianting,
> >
> > On Fri, Dec 02, 2022 at 04:49:39PM -0800, Palmer Dabbelt wrote:
> > > On Wed, 26 Oct 2022 22:42:06 +0800, Xianting Tian wrote:
> > > > As disscussed in below patch set, the patch of 'describe VMCOREINFO export in Documentation'
> > > > need to update according to Bagas's comments.
> > > > https://lore.kernel.org/linux-riscv/22AAF52E-8CC8-4D11-99CB-88DE4D113444@kernel.org/
> > > >
> > > > As others patches in above patch set already applied, so this patch set only contains below two
> > > > patches.
> > > >
> > > > [...]
> > >
> > > Applied, thanks!
> > >
> > > [1/2] RISC-V: Add arch_crash_save_vmcoreinfo support
> > >       https://git.kernel.org/palmer/c/649d6b1019a2
> >
> > So this patch seems to be causing issues for the nommu build:
> > https://lore.kernel.org/oe-kbuild-all/202212062250.tR0otHcz-lkp@intel.com/
> >
> > I had a bit of a poke at trying to see if there were some headers we
> > could pull in before actually checking the .config only to see:
> > # CONFIG_MMU is not set
> >
> > Do we have to wrap the whole thing in a `#ifdef CONFIG_MMU` to fix
> > compilation here?
> The problem does not belong to the patch.
> 
> Could I send a fixup patch? like this?

That seems like a sane dependancy, but did you build that config?
This doesn't fix the problem for me :/

> 
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index ef8d66de5f38..d8c07999426c 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -512,6 +512,7 @@ config ARCH_HAS_KEXEC_PURGATORY
> 
>  config CRASH_DUMP
>         bool "Build kdump crash kernel"
> +       depends on KEXEC
>         help
>           Generate crash dump after being started by kexec. This should
>           be normally only set in special crash dump kernels which are
> 
> >
> > Thanks,
> > Conor.
> >
> 
> 
> -- 
> Best Regards
>  Guo Ren

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)