linux-kernel - Re: [PATCH linux-next] net: record times of netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Dec 2022 16:17:32 +0800 (CST)
From:   <yang.yang29@....com.cn>
To:     <edumazet@...gle.com>
Cc:     <kuba@...nel.org>, <davem@...emloft.net>, <pabeni@...hat.com>,
        <bigeasy@...utronix.de>, <imagedong@...cent.com>,
        <kuniyu@...zon.com>, <petrm@...dia.com>, <liu3101@...due.edu>,
        <wujianguo@...natelecom.cn>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <tedheadster@...il.com>
Subject: Re: [PATCH linux-next] net: record times of netdev_budget exhausted

> Sure, but netdev_budget set to 1 is extreme, don't you think ???

Yes of course, that is just a test to show the difference.

> We prefer not changing /proc file format as much as we can, they are
> deprecated/legacy.

Should we add some explain of the deprecation in code or doc?
As it's deprecated, I think it's NAK for this patch.

> Presumably, modern tracing techniques can let you do what you want
> without adding new counters.

Totally agree.