[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAHp75Vf7Z-ggKryNjHynCo6XgEy=qXq9JY5sXq4Mi_3TiUwhRQ@mail.gmail.com>
Date: Wed, 7 Dec 2022 10:45:59 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: ye.xingchen@....com.cn
Cc: jic23@...nel.org, lars@...afoo.de, jiangjian@...rlc.com,
linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: magnetometer: hmc5843: Convert to use
sysfs_emit_at() API
On Wed, Dec 7, 2022 at 9:51 AM <ye.xingchen@....com.cn> wrote:
>
> From: ye xingchen <ye.xingchen@....com.cn>
>
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
Reviewed-by: Andy Shevchenko <andy.shevchenko@...i.com>
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
> ---
> drivers/iio/magnetometer/hmc5843_core.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/iio/magnetometer/hmc5843_core.c b/drivers/iio/magnetometer/hmc5843_core.c
> index c5521d61da29..134f6045e24a 100644
> --- a/drivers/iio/magnetometer/hmc5843_core.c
> +++ b/drivers/iio/magnetometer/hmc5843_core.c
> @@ -274,9 +274,9 @@ ssize_t hmc5843_show_samp_freq_avail(struct device *dev,
> int i;
>
> for (i = 0; i < data->variant->n_regval_to_samp_freq; i++)
> - len += scnprintf(buf + len, PAGE_SIZE - len,
> - "%d.%d ", data->variant->regval_to_samp_freq[i][0],
> - data->variant->regval_to_samp_freq[i][1]);
> + len += sysfs_emit_at(buf, len, "%d.%d ",
> + data->variant->regval_to_samp_freq[i][0],
> + data->variant->regval_to_samp_freq[i][1]);
>
> /* replace trailing space by newline */
> buf[len - 1] = '\n';
> @@ -335,8 +335,7 @@ static ssize_t hmc5843_show_scale_avail(struct device *dev,
> int i;
>
> for (i = 0; i < data->variant->n_regval_to_nanoscale; i++)
> - len += scnprintf(buf + len, PAGE_SIZE - len,
> - "0.%09d ", data->variant->regval_to_nanoscale[i]);
> + len += sysfs_emit_at(buf, len, "0.%09d ", data->variant->regval_to_nanoscale[i]);
>
> /* replace trailing space by newline */
> buf[len - 1] = '\n';
> --
> 2.25.1
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists