linux-kernel - Re: [PATCH] platform/chrome: cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 7 Dec 2022 20:08:44 +1100
From:   Victor Ding <victording@...omium.org>
To:     Prashant Malani <pmalani@...omium.org>
Cc:     linux-kernel@...r.kernel.org, chrome-platform@...ts.linux.dev,
        tinghan.shen@...iatek.com, gustavoars@...nel.org,
        sebastian.reichel@...labora.com, dnojiri@...omium.org,
        bleung@...omium.org, lee.jones@...aro.org, groeck@...omium.org,
        tzungbi@...nel.org, gregkh@...uxfoundation.org, dustin@...ett.net
Subject: Re: [PATCH] platform/chrome: cros_ec_typec: zero out stale pointers

Hi Prashant,

Thank you for reviewing. I'll update accordingly in the next revision.

On Wed, Dec 7, 2022 at 7:02 PM Prashant Malani <pmalani@...omium.org> wrote:
>
> Hi Victor,
>
> On Tue, Dec 6, 2022 at 8:02 PM Victor Ding <victording@...omium.org> wrote:
> >
> > `cros_typec_get_switch_handles` allocates several pointers when
> > obtaining four handles. These pointers are all freed if failing to
> > obtain any of the four handles; therefore, pointers in `port` becomes
> > stale. The stale pointers eventually cause use-after-free or double in
> > later code paths.
> >
> > This patch proposes
> Please use the imperative form [1]
>
> > to elimite these stale pointers by zeroing them out
>
> s/elimite/eliminate
>
> > right after they are freed.
> >
> > Signed-off-by: Victor Ding <victording@...omium.org>
> This should have a "Fixes" tag.
>
> Best regards,
>
> -Prashant
>
> [1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes

Best regards,
Victor