linux-kernel - Re: linux-next: Signed-off-by missing for commit in the v4l-dvb-next tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e250c025-65c4-1760-bcfe-7efb116b5c9d@xs4all.nl>
Date:   Wed, 7 Dec 2022 11:08:37 +0100
From:   Hans Verkuil <hverkuil-cisco@...all.nl>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: Signed-off-by missing for commit in the v4l-dvb-next
 tree

On 12/6/22 21:56, Stephen Rothwell wrote:
> Hi all,
> 
> Commits
> 
>   85abf40b56af ("media: ipu3-cio2: make the bridge depend on i2c")
>   ca61babacbe8 ("media: MAINTAINERS: Add Hans de Goede as staging/atomisp maintainer")
> 
> are missing a Signed-off-by from their committer.
> 

They have a SoB, but there is a 'Link:' tag right before that:

commit 85abf40b56af5f3130a4f9dcdb808c7feb64e083
Author: Adam Borowski <kilobyte@...band.pl>
Date:   Fri Sep 16 00:33:18 2022 +0100

    media: ipu3-cio2: make the bridge depend on i2c

    drivers/media/pci/intel/ipu3/cio2-bridge.c: In function ‘cio2_bridge_unregister_sensors’:
    drivers/media/pci/intel/ipu3/cio2-bridge.c:258:17: error: implicit declaration of function ‘i2c_unregister_device’; did you mean ‘spi_unregister_device’? [-Werror=implicit-function-declaration]
      258 |                 i2c_unregister_device(sensor->vcm_i2c_client);
          |                 ^~~~~~~~~~~~~~~~~~~~~
          |                 spi_unregister_device

    Link: https://lore.kernel.org/linux-media/S230142AbiJTWql/20221020224641Z+958@vger.kernel.org
    Signed-off-by: Adam Borowski <kilobyte@...band.pl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@...nel.org>

commit ca61babacbe8ada7a0671f910c22b8758f481c0c
Author: Hans de Goede <hdegoede@...hat.com>
Date:   Wed Nov 23 16:14:47 2022 +0000

    media: MAINTAINERS: Add Hans de Goede as staging/atomisp maintainer

    Add myself as maintainer for the drivers/staging/media/atomisp code.

    Link: https://lore.kernel.org/linux-media/20221123161447.15834-1-hdegoede@redhat.com
    Signed-off-by: Hans de Goede <hdegoede@...hat.com>
    Acked-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@...nel.org>

Could that be the cause? checkpatch doesn't complain about this.

Regards,

	Hans