linux-kernel - [PATCH linux-next] misc: eeprom/idt_89hpesx: use strscpy() to instead of strncpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202212070914242210002@zte.com.cn>
Date:   Wed, 7 Dec 2022 09:14:24 +0800 (CST)
From:   <yang.yang29@....com.cn>
To:     <arnd@...db.de>
Cc:     <u.kleine-koenig@...gutronix.de>,
        <wsa+renesas@...g-engineering.com>, <benjamin.mugnier@...s.st.com>,
        <andriy.shevchenko@...ux.intel.com>, <error27@...il.com>,
        <justinstitt@...gle.com>, <linux-kernel@...r.kernel.org>,
        <xu.panda@....com.cn>, <yang.yang29@....com.cn>
Subject: [PATCH linux-next] misc: eeprom/idt_89hpesx: use strscpy() to instead of
 strncpy() 

From: Xu Panda <xu.panda@....com.cn>

The implementation of strscpy() is more robust and safer.
That's now the recommended way to copy NUL terminated strings.

Signed-off-by: Xu Panda <xu.panda@....com.cn>
Signed-off-by: Yang Yang <yang.yang29@....com>
---
 drivers/misc/eeprom/idt_89hpesx.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c
index 4e07ee9cb500..57b985fe59f4 100644
--- a/drivers/misc/eeprom/idt_89hpesx.c
+++ b/drivers/misc/eeprom/idt_89hpesx.c
@@ -941,8 +941,7 @@ static ssize_t idt_dbgfs_csr_write(struct file *filep, const char __user *ubuf,
 			goto free_buf;
 		}
 		/* Copy the register address to the substring buffer */
-		strncpy(csraddr_str, buf, csraddr_len);
-		csraddr_str[csraddr_len] = '\0';
+		strscpy(csraddr_str, buf, csraddr_len + 1);
 		/* Register value must follow the colon */
 		csrval_str = colon_ch + 1;
 	} else /* if (str_colon == NULL) */ {
-- 
2.15.2