lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b049ad99-3859-45f3-5292-5ac53260f4ee@gmail.com>
Date:   Wed, 7 Dec 2022 11:37:48 +0000
From:   Daniel Scally <djrscally@...il.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Miaoqian Lin <linmq006@...il.com>
Cc:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] device property: Fix documentation for
 fwnode_get_next_parent()


On 07/12/2022 11:32, Andy Shevchenko wrote:
> On Wed, Dec 07, 2022 at 03:22:18PM +0400, Miaoqian Lin wrote:
>> Use fwnode_handle_put() on the node pointer to release the refcount.
>> Change fwnode_handle_node() to fwnode_handle_put().
> Looks correct to me, thanks!
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>


And to me too:


Reviewed-by: Daniel Scally <djrscally@...il.com>

>
>> Fixes: 233872585de1 ("device property: Add fwnode_get_next_parent()")
>> Signed-off-by: Miaoqian Lin <linmq006@...il.com>
>> ---
>>  drivers/base/property.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/base/property.c b/drivers/base/property.c
>> index 2a5a37fcd998..daa1e379762b 100644
>> --- a/drivers/base/property.c
>> +++ b/drivers/base/property.c
>> @@ -601,7 +601,7 @@ EXPORT_SYMBOL_GPL(fwnode_get_parent);
>>   * node's parents.
>>   *
>>   * Returns a node pointer with refcount incremented, use
>> - * fwnode_handle_node() on it when done.
>> + * fwnode_handle_put() on it when done.
>>   */
>>  struct fwnode_handle *fwnode_get_next_parent(struct fwnode_handle *fwnode)
>>  {
>> -- 
>> 2.25.1
>>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ