linux-kernel - Re: [PATCH v5] wifi: rtl8xxxu: fixing IQK failures for rtl8192eu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h6y7mm3j.fsf@kernel.org>
Date:   Wed, 07 Dec 2022 14:31:28 +0200
From:   Kalle Valo <kvalo@...nel.org>
To:     Ping-Ke Shih <pkshih@...ltek.com>
Cc:     Jun ASAKA <JunASAKA@...040330.moe>,
        "Jes.Sorensen\@gmail.com" <Jes.Sorensen@...il.com>,
        "davem\@davemloft.net" <davem@...emloft.net>,
        "edumazet\@google.com" <edumazet@...gle.com>,
        "kuba\@kernel.org" <kuba@...nel.org>,
        "pabeni\@redhat.com" <pabeni@...hat.com>,
        "linux-wireless\@vger.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev\@vger.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5] wifi: rtl8xxxu: fixing IQK failures for rtl8192eu

Ping-Ke Shih <pkshih@...ltek.com> writes:

>> >> Fixing "Path A RX IQK failed" and "Path B RX IQK failed"
>> >> issues for rtl8192eu chips by replacing the arguments with
>> >> the ones in the updated official driver as shown below.
>> >> 1. https://github.com/Mange/rtl8192eu-linux-driver
>> >> 2. vendor driver version: 5.6.4
>> >>
>> >> Tested-by: Jun ASAKA <JunASAKA@...040330.moe>
>> >> Signed-off-by: Jun ASAKA <JunASAKA@...040330.moe>

The assumption is that the patch submitter tests the patches, so a
separate Tested-by tag is not needed. I'll remove it.

>> >> Reviewed-by: Ping-Ke Shih <pkshih@...ltek.com>
>> >> ---
>> >> v5:
>> >>   - no modification.
>> > Then, why do you need v5?
>> Well,  I just want to add the "Reviewed-By" line to the commit message.
>> Sorry for the noise if there is no need to do that.
>
> No need to add "Reviewed-By". Kalle will add it when this patch gets merged.

Yeah. And to be precise patchwork actually does that automatically, a
very nice feature :)

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches