linux-kernel - Re: [PATCH 1/2] spi: spi-fsl-lpspi: support multiple cs for lpspi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y5CYsDFdAEduswvm@sirena.org.uk>
Date:   Wed, 7 Dec 2022 13:44:16 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Dhruva Gole <d-gole@...com>
Cc:     Han Xu <han.xu@....com>, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org
Subject: Re: [PATCH 1/2] spi: spi-fsl-lpspi: support multiple cs for lpspi

On Wed, Dec 07, 2022 at 12:08:43PM +0530, Dhruva Gole wrote:
> On 07/12/22 04:24, Han Xu wrote:
> > support to get chip select number from DT file.

> > +		fsl_lpspi->num_cs = 1;
> I am not sure I understand why you are setting this to 1 here?
> I am assuming it is because you want num_cs to default to 1 if
> it is not specified in DT.

> Please can you also add a dev_err and be sure to warn about this?

The binding says that this property is optional with a default of 1 so
it should be totally fine for a system to not specify anything.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)