linux-kernel - Re: [PATCH net] net: defxx: Fix missing err handling in dfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y5Cb4EMML3f0Ivdx@nanopsycho>
Date:   Wed, 7 Dec 2022 14:57:52 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Yongqiang Liu <liuyongqiang13@...wei.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        macro@...am.me.uk, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, ralf@...ux-mips.org,
        jeff@...zik.org, akpm@...ux-foundation.org, zhangxiaoxu5@...wei.com
Subject: Re: [PATCH net] net: defxx: Fix missing err handling in dfx_init()

Wed, Dec 07, 2022 at 08:20:45AM CET, liuyongqiang13@...wei.com wrote:
>When eisa_driver_register() or tc_register_driver() failed,
>the modprobe defxx would fail with some err log as follows:
>
> Error: Driver 'defxx' is already registered, aborting...
>
>Fix this issue by adding err hanling in dfx_init().
>
>Fixes: e89a2cfb7d7b5 ("[TC] defxx: TURBOchannel support")
>Signed-off-by: Yongqiang Liu <liuyongqiang13@...wei.com>

Reviewed-by: Jiri Pirko <jiri@...dia.com>