linux-kernel - [PATCH v2 2/2] MIPS: BCM63xx: Add check for NULL for clk in clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed,  7 Dec 2022 17:28:24 +0300
From:   Anastasia Belova <abelova@...ralinux.ru>
To:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc:     Anastasia Belova <abelova@...ralinux.ru>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Maxime Bizon <mbizon@...ebox.fr>,
        Ralf Baechle <ralf@...ux-mips.org>, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org,
        kernel test robot <lkp@...el.com>
Subject: [PATCH v2 2/2] MIPS: BCM63xx: Add check for NULL for clk in clk_enable

Errors from previous version of patch fixed.
Check clk for NULL before calling clk_enable_unlocked where clk
is dereferenced. There is such check in other implementations
of clk_enable.

Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs.")
Reported-by: kernel test robot <lkp@...el.com>
Signed-off-by: Anastasia Belova <abelova@...ralinux.ru>
---
 arch/mips/bcm63xx/clk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/bcm63xx/clk.c b/arch/mips/bcm63xx/clk.c
index 401140cf36d9..cf303d6e6693 100644
--- a/arch/mips/bcm63xx/clk.c
+++ b/arch/mips/bcm63xx/clk.c
@@ -362,7 +362,7 @@ static struct clk clk_periph = {
 int clk_enable(struct clk *clk)
 {
 	if (!clk)
-		return;
+		return 0;
 
 	mutex_lock(&clocks_mutex);
 	clk_enable_unlocked(clk);
-- 
2.30.2