linux-kernel - Re: [PATCH] ARM: zynq: Fix refcount leak in zynq_early_slcr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d1abd7c7-299b-4a2b-456c-2c0e0ef6436a@amd.com>
Date:   Wed, 7 Dec 2022 15:42:06 +0100
From:   Michal Simek <michal.simek@....com>
To:     Qiheng Lin <linqiheng@...wei.com>
CC:     <michal.simek@...inx.com>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: zynq: Fix refcount leak in zynq_early_slcr_init

Hi,

On 11/29/22 15:05, Qiheng Lin wrote:
> 
> of_find_compatible_node() returns a node pointer with refcount incremented,
> we should use of_node_put() on error path.
> Add missing of_node_put() to avoid refcount leak.
> 
> Fixes: 3329659df030 ("ARM: zynq: Simplify SLCR initialization")
> Signed-off-by: Qiheng Lin <linqiheng@...wei.com>
> ---
>   arch/arm/mach-zynq/slcr.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-zynq/slcr.c b/arch/arm/mach-zynq/slcr.c
> index 37707614885a..9765b3f4c2fc 100644
> --- a/arch/arm/mach-zynq/slcr.c
> +++ b/arch/arm/mach-zynq/slcr.c
> @@ -213,6 +213,7 @@ int __init zynq_early_slcr_init(void)
>          zynq_slcr_regmap = syscon_regmap_lookup_by_compatible("xlnx,zynq-slcr");
>          if (IS_ERR(zynq_slcr_regmap)) {
>                  pr_err("%s: failed to find zynq-slcr\n", __func__);
> +               of_node_put(np);
>                  return -ENODEV;
>          }
> 
> --
> 2.32.0
> 

Applied.

Thanks,
Michal