[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20221207161154.clgmuweddljvco5n@houat>
Date: Wed, 7 Dec 2022 17:11:54 +0100
From: Maxime Ripard <maxime@...no.tech>
To: Maíra Canal <mcanal@...lia.com>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Daniel Vetter <daniel@...ll.ch>,
Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>,
David Gow <davidgow@...gle.com>,
Dave Stevenson <dave.stevenson@...pberrypi.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Javier Martinez Canillas <javierm@...hat.com>,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
linaro-mm-sig@...ts.linaro.org,
Brendan Higgins <brendan.higgins@...ux.dev>,
linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
Maíra Canal <mairacanal@...eup.net>,
linux-media@...r.kernel.org
Subject: Re: [PATCH v3 18/20] drm/vc4: tests: Fail the current test if we
access a register
Hi Maíra,
Thanks for your review!
On Wed, Dec 07, 2022 at 11:26:13AM -0300, Maíra Canal wrote:
> On 12/1/22 12:11, Maxime Ripard wrote:
> > Accessing a register when running under kunit is a bad idea since our
> > device is completely mocked.
> >
> > Fail the current test if we ever access any of our hardware registers.
> >
> > Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>
> > Signed-off-by: Maxime Ripard <maxime@...no.tech>
>
> Reviewed-by: Maíra Canal <mcanal@...lia.com>
>
> Just a small nit: I believe that macros with multiple statements should be
> enclosed in a do-while block [1], even READ macros. I saw that you enclosed
> the WRITE macros on a do-while block, but not the READ macros.
This is on purpose: do-while blocks don't return a value, but ({ ... })
blocks do. So we can do a write macros with a do-while, but can't for
read since we expect to get a value back.
Maxime
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists