linux-kernel - Re: [PATCH v2] tracing: Add trace_trigger kernel command line option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221208183945.1de18843@gandalf.local.home>
Date:   Thu, 8 Dec 2022 18:39:45 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Ross Zwisler <zwisler@...gle.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Linux Trace Kernel <linux-trace-kernel@...r.kernel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        paulmck@...nel.org, Joel Fernandes <joel@...lfernandes.org>,
        Tom Zanussi <zanussi@...nel.org>
Subject: Re: [PATCH v2] tracing: Add trace_trigger kernel command line
 option

On Thu, 8 Dec 2022 15:27:07 -0700
Ross Zwisler <zwisler@...gle.com> wrote:

> > +#ifdef CONFIG_HIST_TRIGGERS  
> 
> Can you help me understand why this is only available if
> CONFIG_HIST_TRIGGERS is selected in the kernel config?  AFAICT this
> code doesn't depend on the histogram code, and the run-time selection
> of triggers is usable without CONFIG_HIST_TRIGGERS.

Good catch!

I got confused, and only saw that as "CONFIG_TRIGGERS" and wasn't thinking
that config was just for histogram triggers :-p

Care to send a patch to fix it?

Thanks Ross,

-- Steve