linux-kernel - Re: [PATCH] RISC-V: Fix unannoted hardirqs-on in return to userspace slow-path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <167054299652.8453.17062801658432513942.b4-ty@rivosinc.com>
Date:   Thu, 08 Dec 2022 15:43:16 -0800
From:   Palmer Dabbelt <palmer@...osinc.com>
To:     Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Andrew Bresticker <abrestic@...osinc.com>
Cc:     linux-kernel@...r.kernel.org, Atish Patra <atishp@...osinc.com>,
        Guo Ren <guoren@...nel.org>, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH] RISC-V: Fix unannoted hardirqs-on in return to userspace slow-path

On Fri, 11 Nov 2022 17:31:08 -0500, Andrew Bresticker wrote:
> The return to userspace path in entry.S may enable interrupts without the
> corresponding lockdep annotation, producing a splat[0] when DEBUG_LOCKDEP
> is enabled. Simply calling __trace_hardirqs_on() here gets a bit messy
> due to the use of RA to point back to ret_from_exception, so just move
> the whole slow-path loop into C. It's more readable and it lets us use
> local_irq_{enable,disable}(), avoiding the need for manual annotations
> altogether.
> 
> [...]

Applied, thanks!

[1/1] RISC-V: Fix unannoted hardirqs-on in return to userspace slow-path
      https://git.kernel.org/palmer/c/e1ceb0964163

Best regards,
-- 
Palmer Dabbelt <palmer@...osinc.com>