[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1015c275-cf02-ce67-964e-c240d973261d@socionext.com>
Date: Thu, 8 Dec 2022 15:37:21 +0900
From: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
To: Rob Herring <robh@...nel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Masami Hiramatsu <mhiramat@...nel.org>,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 09/16] dt-bindings: soc: socionext: Add UniPhier
SoC-glue logic
Hi Rob,
On 2022/12/08 0:35, Rob Herring wrote:
> On Wed, Dec 07, 2022 at 02:53:58PM +0900, Kunihiko Hayashi wrote:
>> Add devicetree binding schema for the SoC-glue logic implemented on
>> Socionext Uniphier SoCs.
>>
>> This SoC-glue logic is a set of miscellaneous function registers
>> handling signals for specific devices outside system components,
>> and also has multiple functions such as I/O pinmux, usb-phy, debug,
>> clock-mux for a specific SoC, and so on.
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
>> ---
(snip)
>> +allOf:
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - socionext,uniphier-pro4-soc-glue
>> + - socionext,uniphier-ld11-soc-glue
>> + else:
>> + patternProperties:
>> + "^usb-hub(@[0-9a-f]+)?$": false
>
> While just if and else is valid json-schema, we require 'then'. Can you
> change this to 'if: { not: {...}, then: {}'.
I see. I'll rewrite it with invert condition.
> You should be getting a warning for this. The rest of the warnings from
> the bot look like false positives you can ignore.
Hmm, I couldn't see the warning for this condition.
The warnings your bot printed are the results evaluated before
applying the example fixes (PATCH 1-7) or before fixing the
existing devicetree (need to fix but yet).
Thank you,
---
Best Regards
Kunihiko Hayashi
Powered by blists - more mailing lists