linux-kernel - Re: [PATCH] dt-bindings: interrupt-controller: loongarch: Fix mismathed compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6604d25f-f5f9-332d-bd2d-08706380c935@linaro.org>
Date:   Thu, 8 Dec 2022 09:42:28 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Liu Peibao <liupeibao@...ngson.cn>, Rob Herring <robh@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <maz@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Huacai Chen <chenhuacai@...nel.org>,
        WANG Xuerui <kernel@...0n.name>
Cc:     Jianmin Lv <lvjianmin@...ngson.cn>,
        Yinbo Zhu <zhuyinbo@...ngson.cn>,
        wanghongliang <wanghongliang@...ngson.cn>,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: interrupt-controller: loongarch: Fix
 mismathed compatible

On 08/12/2022 04:02, Liu Peibao wrote:
> The "compatible" doesn't match what the kernel is using. Fix it as
> kernel using.
> 
> Fixes: 855d4ca4bdb3 ("irqchip: loongarch-cpu: add DT support")

Really? You just added these patches...

1.  In the same time Loongson people keep pinging for accepting these:
https://lore.kernel.org/all/e3bf1f8a-e37e-46e3-f9b3-20a9031d49e2@loongson.cn/
https://lore.kernel.org/all/f5d0f796-0147-8789-5bed-edf38b28229e@loongson.cn/

All the time - several pings, every week.

2. In the last weeks, two of your engineers sent the same driver
(Loongson I2C) in the same time, with different names! For the same
hardware.

3. Several other patches from Loongson, when posted on mailing lists,
have multiple compile warnings. This suggests they were not really
compiled properly (with different test configs, with W=1, smatch,
sparse, coccinelle). There were so many compiler warnings, that I assume
your patches should wait on mailing list for two weeks before starting
any review. Otherwise it's a bit waste of reviewer's effort.

Patches are welcomed but all this points on poor quality of submissions
and sending anything, hoping it will get merged upstream, regardless of
quality.

I appreciate fixing the patch fast, it's a good sign, but maybe Loongson
could a bit improve internal processes of review before sending and
pinging on mailing list?

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof