[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d9e92880-6efe-a528-efa8-2c49483d8530@linaro.org>
Date: Thu, 8 Dec 2022 10:01:30 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: William Qiu <william.qiu@...rfivetech.com>,
linux-riscv@...ts.infradead.org, devicetree@...r.kernel.org,
linux-mmc@...r.kernel.org
Cc: Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Jaehoon Chung <jh80.chung@...sung.com>,
Ulf Hansson <ulf.hansson@...aro.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/3] dt-bindings: mmc: Add bindings for StarFive
On 08/12/2022 09:44, William Qiu wrote:
>
>>> +
>>> + clock-names:
>>> + minItems: 1
>>> + items:
>>> + - const: biu
>>> + - const: ciu
>>> +
>>> + interrupts:
>>> + maxItems: 1
>>> +
>>> + starfive,sys-syscon:
>>> + $ref: /schemas/types.yaml#/definitions/uint32-array
>>> + description:
>>> + The desired number of times that the host execute tuning when needed.
>>
>> That's not matching the property name. Missing number of items... this
>> is anyway confusing. Why number of tuning tries is a property of DT?
>>
>
> Will update the description.
I propose first to explain what is it. Because it is not about
description only, but also type. Your driver uses this as syscon, so
this cannot be uint32-array but phandle-array...
Best regards,
Krzysztof
Powered by blists - more mailing lists