linux-kernel - Re: [PATCH 2/2] dt-bindings: leds: Add missing references to common LED schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Dec 2022 10:28:50 +0100
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Rob Herring <robh@...nel.org>
Cc:     Pavel Machek <pavel@....cz>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Yi Xin <Yixin.zhu@...el.com>,
        Mallikarjuna reddy <mallikarjunax.reddy@...el.com>,
        Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [PATCH 2/2] dt-bindings: leds: Add missing references to common
 LED schema

On Wed, Dec 7, 2022 at 9:43 PM Rob Herring <robh@...nel.org> wrote:
>
> 'led' nodes should have a reference to LED common.yaml schema. Add it where
> missing and drop any duplicate properties.
>
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---

>  .../devicetree/bindings/leds/leds-max77650.yaml  |  9 ++-------

> diff --git a/Documentation/devicetree/bindings/leds/leds-max77650.yaml b/Documentation/devicetree/bindings/leds/leds-max77650.yaml
> index c6f96cabd4d1..fdb08f44a45d 100644
> --- a/Documentation/devicetree/bindings/leds/leds-max77650.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-max77650.yaml
> @@ -30,9 +30,8 @@ properties:
>
>  patternProperties:
>    "^led@[0-2]$":
> -    type: object
> -    description: |
> -      Properties for a single LED.
> +    $ref: common.yaml#
> +    unevaluatedProperties: false
>
>      properties:
>        reg:
> @@ -41,10 +40,6 @@ patternProperties:
>          minimum: 0
>          maximum: 2
>
> -      label: true
> -
> -      linux,default-trigger: true
> -
>  required:
>    - compatible
>    - "#address-cells"

Acked-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>