linux-kernel - Re: [PATCH v8 0/3] Add Richtek RT9471 3A battery charger support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221208094445.GA14085@cyhuang-hp-elitebook-840-g3.rt>
Date:   Thu, 8 Dec 2022 17:44:50 +0800
From:   ChiYuan Huang <u0084500@...il.com>
To:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        sre@...nel.org
Cc:     mazziesaccount@...il.com, alina_yu@...htek.com,
        cy_huang@...htek.com, alinayu829@...il.com,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 0/3] Add Richtek RT9471 3A battery charger support

On Fri, Sep 30, 2022 at 10:50:06PM +0800, cy_huang wrote:
> From: ChiYuan Huang <cy_huang@...htek.com>
> 
> This patch set is to add Richtek RT9471 charger support.
> 
> The RT9471/D is a highly-integrated 3A switch mode battery charge management
> and system power path management device for single cell Li-Ion and Li-polymer
> battery. The low impedance power path optimizes switch-mode operation
> efficiency, reduces battery charging time and extends battery life during
> discharging phase.
>
Hi,
  This patch series was pending almost 2 month.

For the below question
Does it mean to remove 'sysoff_enable' attribute and no more discussion?
https://lore.kernel.org/lkml/CADiBU39FMkDOrMHXTQF+0JGX2tDn_iVXCb19jM6MopnKmaXOpQ@mail.gmail.com/


v7
https://lore.kernel.org/lkml/1664531079-15915-1-git-send-email-u0084500@gmail.com/
v8
https://lore.kernel.org/lkml/1664549409-4280-1-git-send-email-u0084500@gmail.com/
For v7/v8, it may be my fault.
Because I could not get any reply, that's why I try to find any missing header or code
defect to be fixed. I know the version tags make others confused.
I'm sorry about that.

Still hope to get any feedback for the finalized v9 version.

Thanks.


> Since v8:
> - revert v7 for adding irq wakeup capable, i2c core already did it.
> 
> Since v7:
> - Add irq wakeup capable.
> - Add missing header 'module.h' for MODULE_DEVICE_TABLE.
> 
> Since v6:
> - Use 'ATTRIBUTE_GROUPS' macro to simplify the attribute coding.
> - Explain more details for sysoff_enable attribute.
> 
> Since v5:
> - Remove one line wrapper.
> - Merge header content into source file, remove header file.
> - Remove 'charge_term_enable' sysfs entry and merge it into
>   'charge_term_current' property control.
> - Change MODULE_LICENSE from 'GPL v2' to 'GPL'.
>   Following by the below discussion
>   https://lore.kernel.org/all/YxAVAt2eWB3NFlrk@google.com/
> - Recover all the change in sysfs-class-power.
> - New a sysfs-class-power-rt9471 file.
> - Remove 'charge_term_enable' sysfs entry, directly integrate it in
>   'charge_term_current' power supply property control.
> 
> Since v4:
> - Remove the line for the owner field in driver.
> - Add the documentation for sysfs entries.
> 
> Since v3:
> - Move unevaluatedProperties line after $ref for binding patch.
> - Add Reviewed-by tag for binding patch.
> 
> Since v2:
> - Remove the properties for interrupt controller things in the binding documentation.
> - Fix dtc error for typo, it's 'regulator-name', not 'regulator-compatible'.
> - Add regulator min/max microamp to allow otg vbus current adjustable in example.
> - Specify the active-level for charge-enable-gpios in binding example.
> - Fix checkpatch error about 'foo * bar' to 'foo *bar' in psy_device_to_chip function.
> - Specify the member name directly for the use of linear range.
> 
> ChiYuan Huang (3):
>   dt-bindings: power: supply: Add Richtek RT9471 battery charger
>   power: supply: rt9471: Add Richtek RT9471 charger driver
>   Documentation: power: rt9471: Document exported sysfs entries
> 
>  Documentation/ABI/testing/sysfs-class-power-rt9471 |  32 +
>  .../bindings/power/supply/richtek,rt9471.yaml      |  73 ++
>  drivers/power/supply/Kconfig                       |  16 +
>  drivers/power/supply/Makefile                      |   1 +
>  drivers/power/supply/rt9471.c                      | 931 +++++++++++++++++++++
>  5 files changed, 1053 insertions(+)
>  create mode 100644 Documentation/ABI/testing/sysfs-class-power-rt9471
>  create mode 100644 Documentation/devicetree/bindings/power/supply/richtek,rt9471.yaml
>  create mode 100644 drivers/power/supply/rt9471.c
> 
> -- 
> 2.7.4
>